[abhishekacharya200]

Fixes #18936

load_table_from_dataframe and load_table_from_json take a timeout, but the get_table(destination) call they make before uploading didn't receive it. BigQuery's DEFAULT_TIMEOUT is None, so that request had no timeout at all and could hang however short a timeout the caller set.

This passes timeout to both lookups. Callers who don't set one still get None, as before. Both methods type timeout as ResumableTimeoutType, which can be a (connect, read) tuple; get_table hands it to the same HTTP layer, so a tuple works there too, though the tests only use a float.

Added test_load_table_from_dataframe_passes_timeout_to_table_lookup and test_load_table_from_json_passes_timeout_to_table_lookup, which fail on main and pass with this change. tests/unit/test_client.py passes (285 passed, 1 skipped). black 23.7.0 and flake8 report nothing on the changed files.

This is the same gap as #18767, in two other methods, and the two PRs don't touch the same lines.

• Issue opened for this bug (bigquery: load_table_from_dataframe and load_table_from_json drop timeout on the table lookup #18936)
• Tests and linter pass
• Code coverage does not decrease

[gemini-code-assist]

Code Review

This pull request ensures that the timeout parameter is correctly passed to the get_table lookup in both load_table_from_dataframe and load_table_from_json methods of the BigQuery client. Corresponding unit tests have been added to verify this behavior. I have no feedback to provide as there are no review comments.

[parthea]

Thanks for opening a PR @abhishekacharya200, please could you take a look at the mypy failure in https://github.com/googleapis/google-cloud-python/actions/runs/41204145322/job/126019710987?pr=18937?

google/cloud/bigquery/client.py:2987: error: Argument "timeout" to "get_table" of "Client" has incompatible type "float | tuple[float, float] | None"; expected "float | None"  [arg-type]
google/cloud/bigquery/client.py:3175: error: Argument "timeout" to "get_table" of "Client" has incompatible type "float | tuple[float, float] | None"; expected "float | None"  [arg-type]

We may need something like this

                    # `timeout` can be a `(connect_timeout, read_timeout)` tuple
                    # (`ResumableTimeoutType`), whereas `get_table` only accepts a
                    # single float (`TimeoutType`). To avoid changing `get_table`'s
                    # public signature (and sending a tuple in `X-Server-Timeout`),
                    # extract `connect_timeout` when a tuple is passed.
                    get_table_timeout = (
                        timeout[0] if isinstance(timeout, tuple) else timeout
                    )

[abhishekacharya200]

Thanks @parthea, fixed. The load methods allow a (connect, read) tuple and get_table is typed as float, so I cast it there; requests accepts both. mypy passes locally now.