Skip to content

Add a figure_format themeable - #1127

Merged
has2k1 merged 1 commit into
mainfrom
figure-format-themeable
Sep 21, 2026
Merged

has2k1 merged 1 commit into
mainfrom
figure-format-themeable

Conversation

@has2k1

@has2k1 has2k1 commented Sep 21, 2026

Copy link
Copy Markdown
Owner

This PR adds figure_format theme control for notebook display and default saves.

Let plot and composition themes select notebook and default save formats while preserving explicit format and filename precedence. Propagate the selected format to nested plots, guides, and insets, and render SVG colourbars as overlapping rectangles without mutating their configured display mode.
@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.50%. Comparing base (0e8f227) to head (936b057).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
plotnine/composition/_compose.py 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
+ Coverage   88.12%   88.50%   +0.37%     
==========================================
  Files         226      226              
  Lines       16579    16613      +34     
  Branches     2121     2130       +9     
==========================================
+ Hits        14611    14703      +92     
+ Misses       1356     1295      -61     
- Partials      612      615       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@has2k1
has2k1 merged commit 936b057 into main Sep 21, 2026
14 checks passed
@has2k1
has2k1 deleted the figure-format-themeable branch September 21, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant