Repository navigation
fix(geom_path): allow layers without data - #1136
Merged
Merged
Conversation
has2k1
reviewed
Oct 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
==========================================
- Coverage 88.87% 88.87% -0.01%
==========================================
Files 229 229
Lines 17292 17291 -1
Branches 2203 2203
==========================================
- Hits 15368 15367 -1
Misses 1295 1295
Partials 629 629 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plotting an empty data frame with a path based layer raises a
KeyError:The same happens with
geom_freqpolyandgeom_qq_line. When a stat gets no rows it returns no computed columns, so the layer data has noy.geom_path.handle_nathen selects["x", "y", "size", "color", "linetype"]strictly. Other geoms (e.g.geom_histogram,geom_density) already draw nothing in this case, and ggplot2'sGeomPath$handle_naonly looks at the columns that are present (data[names(data) %in% c(...)]).This makes
handle_nause only the columns that exist.Testing: added
test_empty_layer_data, which fails on main and passes with the fix.tests/test_geom_path_line_step.py,tests/test_stat_ecdf.py,tests/test_geom_freqpoly.pyandtests/test_geom_qq_qq_line.pypass, ruff is clean. Added a changelog entry under Bug Fixes.