Skip to content

closed - #113

Closed
ghost wants to merge 6 commits into
mainfrom
unknown repository
Closed

closed#113
ghost wants to merge 6 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Sep 17, 2026 •

Copy link
Copy Markdown

closed

arash added 6 commits September 16, 2026 13:21
Port Strings.fa.resx and the content-only FlowDirection sync
(App.xaml/App.xaml.cs, LanguagePackControl, UpdaterWindow,
WelcomeDialog) from the codesbygom DS4Windows fork.
Global.Save() was commented out in ChangeLanguagePack(), so a new
language selection only lived in memory: the "restart required"
prompt fired, but the saved config still had the old UseLang, so
the app came back up in the previous language every time.
Twelve panels (About, ControllerOverview, AudioHaptics, ViiperSetupPrompt/
Progress, MappingLiveInput, TriggerLab, SwipeProfilesEditor,
Switch2StickCalibration, LogMessageDisplay, StickCalibration,
TouchButtonUserControl) had zero WPFLocalizeExtension bindings, so their
text stayed English regardless of the selected language pack. Wired all of
them to {lex:Loc}/Properties.Resources, keeping license text, proper nouns,
usernames, URLs, and unit suffixes (ms, Hz) untranslated as appropriate.

Also:
- Added the 4 keys missing from Strings.fa.resx and translated 2 tooltips
  that were copied verbatim from English.
- Created Properties/Resources.fa.resx (the legacy resx family used by
  ~200 Properties.Resources.* call sites) and uncommented
  DS4WinWPF.Properties.Resources.Culture = ci; in SetUICulture, which was
  never actually switching that resource family's culture.
- Registered Strings.fa.resx and Resources.fa.resx in the csproj
  (DependentUpon metadata) to match the other language entries.
- Fixed a latent bug in TriggerLabControl's MakeMeter: the slider's
  internal property key ("Start"/"Wall"/"Force") was reused as the
  display label, so localizing the label would have silently broken
  meter updates. Split them into separate parameters.

Net: 170 new Strings.resx/Strings.fa.resx keys, 156 new
Properties/Resources.resx/Resources.fa.resx keys, all translated.
Both Strings.ar.resx and Strings.he.resx only had 109 of 619 keys
translated (the rest silently fell back to English). Translated the
remaining 510 keys in each, using the existing human-translated
entries in those same files as the terminology reference (Controller,
Profile, Rumble, Trigger, etc.) to keep vocabulary consistent with
what was already shipped.

Also created Properties/Resources.ar.resx and Resources.he.resx from
scratch (339 keys each) for the legacy Properties.Resources.* call
sites -- neither language had any coverage there before, same gap
fixed for Farsi in the previous commit. Registered both in the csproj.
Resources.resx was edited directly (not through Visual Studio's
designer), so the PublicResXFileCodeGenerator custom tool never ran
and Resources.Designer.cs still only exposed the pre-existing string
properties. Every Properties.Resources.* call site added for the
localization work failed with CS0117 as a result. Added the missing
156 properties by hand, matching the generator's existing pattern.
@ghost

ghost commented Oct 20, 2026

Copy link
Copy Markdown
Author

Superseded by #150 (Arabic) and #151 (Hebrew), which build on #147 so the translations also reach text written directly in XAML.

@ghost ghost closed this Oct 20, 2026
@ghost ghost changed the title Complete Arabic and Hebrew localization coverage closed Nov 1, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants