Skip to content

Integrate dynamic profiles with Anthropic Tool loops - #346

Open
qoli wants to merge 100 commits into
huggingface:mainfrom
qoli:codex/upstream-profile-anthropic
Open

qoli wants to merge 100 commits into
huggingface:mainfrom
qoli:codex/upstream-profile-anthropic

Conversation

@qoli

@qoli qoli commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Scope

Anthropic integration for #315's shared Compatibility SPI. Provider PRs are siblings, not a chain.

Depends on #315 cf4ad0d and #312 697ed57, transitively #314/#313 and main's #352. Isolated layer comparison. The comparison also includes the attachment dependency.

  • Resolve a profile before each actual request and bind callbacks/Tools to that producing request.
  • Preserve canonical/pending history, earlier text, shared nondefault round budgets and the full handoff error payload.
  • Retain ordinary provider history behavior; preserve repeated calls and round-scoped outputs rather than globally deduplicating call IDs.
  • Retain complete committed-entry identity for hooks/Tools and the public raw-Tool boundary.

Ordinary non-streaming remains one request/return and does not build unused in-flight messages. Profile non-streaming continues as already published; its in-flight encoder uses #312's Tool-only MIME placeholder. Thinking/signatures and file-deletion/Codable/native attachment replay are preserved.

Upstream 1.1 synchronization

Normal history-preserving merges synchronize upstream main 7d43219, including #357 per-request usage accounting, #341 Ollama reasoning, #358 host-scoped Chat Completions reasoning, #300 response-start timeouts, #362 cancellation collection, #364 partial structured snapshots and #366/#367 bounds/reasoning/system-Tool fixes. Earlier #336 final-request usage, #340 HTTPTransport, #297/#325/#331/#343/#352/#354/#356 remain intact. No force-push, new checkout, replacement PR or extra fallback.

RequestsUsage.add reports each completed non-streaming request without double-reporting it. Both streaming and profile non-streaming round-limit checks use entries captured before the current round adds reasoning, so the error contains only rounds that ran. Ordinary streaming/profile streaming/profile response regressions first reproduced three failures, then passed. Ordinary non-streaming remains a single HTTP request/return with no unused inFlight encoding; attachment snapshots, Tool-only MIME lowering and Anthropic signatures remain intact.

Fresh local verification (2026-10-23)

Head 4c30d17. CI=1 GIT_CONFIG_GLOBAL=/dev/null swift test: 973 tests / 100 suites passed. The separate upstream macro test target also passed 2 tests / 1 suite. Strict formatting/diff checks passed. These are compile/offline tests, not live API, model-weight or Apple Intelligence inference acceptance.

The offline suites retain streaming/non-streaming history, callback, reused-ID and handoff accounting regressions. Constructor visibility is still SPI; no new PR or force-push.

qoli added 30 commits October 9, 2026 16:00
qoli added 25 commits October 21, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant