Repository navigation
ci: run CI on build-trusted-commits pushes; require empty changesets - #272
Open
trevor-coleman wants to merge 3 commits into
Open
trevor-coleman wants to merge 3 commits into
trevor-coleman wants to merge 3 commits into
Conversation
ci.yml and the EAS build-on-pr workflow only ran on pull_request, so 'yarn ci:trust' pushing fork commits to build-trusted-commits no longer triggered anything. Add a push trigger for that branch to both so results attach to the fork PR's head commit again, and fix the stale usage and branch name in the untrusted-forks docs.
🦋 Changeset detectedLatest commit: e98b454 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Make it explicit in CLAUDE.md and the contributor docs that every PR needs a changeset, using 'yarn changeset --empty' when nothing is released. CI's 'changeset status' only enforces this for published packages.
trevor-coleman
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
yarn ci:trustpushes reviewed fork commits tobuild-trusted-commitsso fork PRs can get CI. Butci.ymland the EASBuild ExampleApp on PRsworkflow both only trigger onpull_request, so that push currently runs nothing. The workaround has been to open a throwaway draft PR frombuild-trusted-commits(e.g. #271).Change
.github/workflows/ci.yml: addpush: branches: [build-trusted-commits]. Theverifyjob'sifand theci-${{ github.ref }}concurrency group already handle push events.apps/ExampleApp/.eas/workflows/build-on-pr.yml: same trigger, so fork PRs get native Android/iOS builds too.CLAUDE.mdanddocs/contributing/changesets-versions-and-releases.md: make it a project rule that every PR includes a changeset, usingyarn changeset --emptywhen no package is bumped.docs/contributing/running-tests-on-untrusted-forks.md: fix the usage (<fork_username>:<fork_branchname>) and the target branch name (build-trusted-commits, nottemp-branch-to-test-fork, which is the temporary remote).Because the pushed commits are identical to the fork PR's, the check results attach to the fork PR's head commit, as the docs describe.
Notes
mainthat includes this change.build-trusted-commitsis also open, each push runs CI twice. Close those once this lands.Verification
actionlintpasses onci.yml.