Repository navigation
Reject the legacy recursive if c order in for loops (0175) - #547
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012DUPAtew1vj5JrPS8aLyHL
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012DUPAtew1vj5JrPS8aLyHL
rmorozov
marked this pull request as ready for review
October 17, 2026 14:35
rmorozov
pushed a commit
that referenced
this pull request
Oct 17, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTQTriEsFrrBgcYNKDUUF4
rmorozov
added a commit
that referenced
this pull request
Oct 17, 2026
Docs: sync task index and parity summary after #547
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ruslan · project thread
Before:
{% for x in l recursive if c %}(the old Jinja2C++ order) parsed next to Jinja2's{% for x in l if c recursive %}, sostatements.loop_recursive_after_filter_reject_ordersat in the statements allow-list.After:
recursiveis accepted only after the filter, as in Jinja2; the legacy order is a parse error ("expected end of statement, got 'if'").2.0 breaking change (default decision, Ruslan can override): templates using
recursive if cmust move toif c recursive.test/arena_switch_test.cppwas the one in-repo user and now uses the new order.How:
ParseForno longer eatsrecursivebefore the filter; the filter's dynamic-region look-ahead (EndsWithRecursive) is unchanged. The divergence line is deleted; the corpus case already exists.Task 0175: the other line (
loop_recursive_filter_sees_outer_loop) was already gone after 0165. The include-in-looploopitem is now pinned asstatements.loop_not_visible_in_include(new corpus case, allow-listed) and filed as task 0209. 0175 is marked done.Roles: none (main session only), no verifier round (small parser change; sanitizer jobs run in CI). One push went red locally before CI: my first version also added a trailing-token check after a filter, which changed the error text for
if true else hello; fixed in the second commit.Generated by Claude Code