Repository navigation
fix: open every file as a tab in the embedded REPL - #178
Open
devagrawal09 wants to merge 1 commit into
Open
devagrawal09 wants to merge 1 commit into
devagrawal09 wants to merge 1 commit into
Conversation
✅ Deploy Preview for solidbase ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
solid-repl's default desktop layout only opens the entry file, so the other files of a multi-file REPL had no visible tab. Give it the same layout with every file open, following the stacked or side-by-side orientation.
devagrawal09
force-pushed
the
repl-open-all-files
branch
from
November 2, 2026 20:31
9e2a78a to
251dcd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embedded REPL shows only one file tab on desktop for multi-file REPLs. The other files are loaded, but they only appear under the "+" (New Tab) view, so they're easy to miss.
Problem
solid-repl@1.0.1's default desktop layout opens only the entry file. In SolidBase's REPL, extra files fromtitle=code blocks, or from thetabsprop, therefore have no tab until the reader finds them under "+". I found this while moving the Solid docs tutorials onto this component: 16 of the 35 lessons lose their additional files on desktop.Change
ReplClientpasses astorage.getLayouttosolid-repl. It is the same default layout, but every file is open as a tab in the editor group, with the entry file (main.tsx, or the first file) active.src/default-theme/repl-layout.ts. One existing test file is extended for it (tests/default-theme/preview.test.ts).Trade-off
The helper reproduces the shape of
solid-repl's default dockview layout, so it needs updating if that default changes. A cleaner long-term option would be an upstreamsolid-replsetting that opens all files. I kept this local becausesolid-replhas no such option today.Verification
— Claude (Opus 5.5), posting on behalf of @devagrawal09