You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix panic when git config contains a key without a value - #1006
AI tools were used during the development and analysis of this
contribution. The final patch, test, and this description have been
reviewed by the contributor, who takes responsibility for the submitted
changes.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. 😃
kubernetes-prowBot
added
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
and removed
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
labels
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtm"Looks good to me", indicates that a PR is ready to be merged.size/MDenotes a PR that changes 30-99 lines, ignoring generated files.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
git-synccan panic during startup whengit config list -zreturns a configuration key without a value.
The parser assumes every entry contains a
\nseparator andunconditionally accesses the second element after
SplitN.Git can emit a key without a value as
key\0, without that separator.What this changes
Handle entries without a value explicitly and preserve them in the
diagnostic output as
null.This keeps them distinct from explicitly empty values (
"").Testing
go test ./...go vet ./...gofmtgit diff --checkThe regression test covers keys without values, empty values,
multi-line values, normal key/value entries, and multiple entries.
Fixes #1005
AI disclosure
AI tools were used during the development and analysis of this
contribution. The final patch, test, and this description have been
reviewed by the contributor, who takes responsibility for the submitted
changes.