Skip to content

Fix panic when git config contains a key without a value - #1006

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
LemonCondor:fix-config-key-without-value
Oct 9, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
LemonCondor:fix-config-key-without-value

Conversation

@LemonCondor

Copy link
Copy Markdown
Contributor

What happened

git-sync can panic during startup when git config list -z
returns a configuration key without a value.

The parser assumes every entry contains a \n separator and
unconditionally accesses the second element after SplitN.

Git can emit a key without a value as key\0, without that separator.

What this changes

Handle entries without a value explicitly and preserve them in the
diagnostic output as null.

This keeps them distinct from explicitly empty values ("").

Testing

  • go test ./...
  • go vet ./...
  • gofmt
  • git diff --check

The regression test covers keys without values, empty values,
multi-line values, normal key/value entries, and multiple entries.

Fixes #1005

AI disclosure

AI tools were used during the development and analysis of this
contribution. The final patch, test, and this description have been
reviewed by the contributor, who takes responsibility for the submitted
changes.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: high-altitude-ai / name: Guillaume Marty (c17a0e3)

@kubernetes-prow
kubernetes-prow Bot requested review from janetkuo and thockin October 8, 2026 20:02
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @high-altitude-ai!

It looks like this is your first PR to kubernetes/git-sync 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/git-sync has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 8, 2026

@thockin thockin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: high-altitude-ai, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 2943b1d into kubernetes:master Oct 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git-sync panics at startup when git config contains a key with no value

2 participants