Repository navigation
test(AIC-3737): cover tools in the handler-owned settings test - #276
Open
jeffdupont wants to merge 1 commit into
Open
jeffdupont wants to merge 1 commit into
jeffdupont wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jeffdupont
marked this pull request as ready for review
November 4, 2026 19:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The claude-messages handler takes
model, the messages, the system prompt andtoolsfrom the config, never frommodel.parameters. The existing test (test_config_cannot_override_model_or_messages) covered every one excepttools. This PR addstools:search), andmodel.parameterssets a differenttoolslist.toolsholds onlysearch, and that the parameters' tool appears nowhere in the call arguments.No handler code changes.
Tests
uv run ruff check .,uv run ruff format --check .: pass.uv run pytest packages/claude-messages: 171 passed.🤖 Generated with Claude Code
Note
Overview
Extends
test_config_cannot_override_model_or_messagessotoolsis covered the same way asmodel, messages, and system: the test config defines asearchtool whilemodel.parameterstries to inject a differenttoolslist.The new assertions check that
messages.createreceives onlysearchfrom top-level config and that the parameters tool never appears in the call kwargs.No handler or production code changes—this only locks in existing handler-owned
toolsbehavior.Reviewed by Cursor Bugbot for commit c73a3d0. Bugbot is set up for automated code reviews on this repo. Configure here.