Repository navigation
Conversation
Signed-off-by: tanav29 <tanavposwal939@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe content and navbar styles update highlight-box shadow behavior when a hidden-highlight-box is hovered or focused. New ChangesHighlight shadow behavior
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The styles now handle hover and focus consistently in either box order on both pages. No material merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tejaswiverma121-byte
left a comment
There was a problem hiding this comment.
the missing items are:
Browser support check for :has()
This is the only real compatibility concern.
:has() is broadly supported in modern Chromium-based browsers, Safari, and current Firefox, but if the docs site has a requirement to support older browsers, this could be an issue.
If compatibility matters, this PR should either:
confirm modern browser support, or
include a fallback pattern (if feasible).
No automated regression coverage
The issue is visual/interaction-based, and there is no automated test for the hover/focus states.
For a CSS bug like this, a quick visual smoke test or browser-based check is the usual minimum validation.
|
The |
vedant21-ctr
left a comment
There was a problem hiding this comment.
Thanks for the fix. The approach looks good and the screenshots show the intended behavior.
could you please do a quick validation on the PR preview:
- Verify the fix on both
/cloudand/kanvas, including mouse-out, to ensure the glow returns correctly. - Please also check the navbar/ecosystem area, since
_navbar_project.scssis changed as well, and confirm the new.pageinfo:has(...)selector actually applies there.
A short video showing these states would be enough.
|
Hi @tanav29, A short screen recording covering the preview validation points mentioned by @vedant21-ctr above (testing both /cloud and /kanvas, checking mouse-out recovery, and confirming the header ecosystem dropdown) would be great to verify everything visually! |
|
@vedant21-ctr @tejaswiverma121-byte The use of .has() is fixing the order problem in
The video showing the hover removing as the mouse leaves the div. below. Screen.Recording.2026-10-08.141827-compressed.mp4 |
tejaswiverma121-byte
left a comment
There was a problem hiding this comment.
Using .has() is the correct solution — it checks if the .hidden-highlight-box is hovered anywhere inside the parent .pageinfo, then dims the highlight box. DOM order no longer matters. LGTM✓
Notes for Reviewers
This PR fixes #1138
Fixed the inconsistent hover effect on
/kanvasand/cloudSigned commits
Summary by CodeRabbit