[paolosalvatori]

Motivation

#47 asks Windows users of Git Bash and MSYS2 to export MSYS_NO_PATHCONV=1 and adapts the scripts to it, but the samples workflow runs only on Linux, so nothing checks that the scripts work from Git Bash.
This adds a Windows job that runs every app there end to end, on demand, as a reproduction of that setup.
It is stacked on #47 and will be retargeted to main once that pull request merges.

Fixes SMF-981

Changes

• A new platform input of the manual run, a dropdown with Windows, Linux (the default) and all, chooses where the selected apps run, and run_mode selects the apps on both platforms. The setup job puts one entry per app and platform in the matrix, each naming its runner and its job, and the one sample job runs them, its Windows-only and Linux-only steps gated on the entry's platform: a run lists only the jobs it runs, Windows (Git Bash) <sample> (<language>) on Windows, and the Linux jobs keep their names.
• A Windows job runs on windows-latest and uses Git Bash, the default bash shell of Windows runners, with MSYS_NO_PATHCONV=1 set as the README asks. For each app it creates the AKS cluster with scripts/01-system-assigned-managed-identity.sh, deploys the app with its numbered scripts and checks it with tests/test-vacation-planner.sh, as the Linux job does, with the same answers to the Azure Files sample's menus and the same cluster state on failure.
• The emulator is a Linux image, and Docker on the Windows runner runs Windows containers, so the job starts Docker Engine inside an Ubuntu WSL 2 distribution (Vampire/setup-wsl) and runs the emulator there with docker run. The Windows docker CLI, lstk and kubectl reach it through ports WSL forwards to the runner's localhost. Installing docker.io already starts a daemon on the Unix socket alone, so the job stops it and starts one that also listens on TCP, and waits on the TCP endpoint.
• As the README asks, bash drops the carriage returns Windows programs print (set -o igncr), turned on for every bash through BASH_ENV, since exporting SHELLOPTS in a step would hand the step's own -e and pipefail to the sample scripts.
• WSL's DNS tunneling is turned off: with it, the containers of the Docker Engine in WSL could not reach WSL's resolver, and the Container Apps runtime could not pull images; without it, WSL hands out the NAT device on the host as the DNS server, which containers reach too.
• lstk 1.4.0 cannot register its Azure CLI cloud on Windows when the CLI sits under C:\Program Files: it passes the cloud configuration's JSON to az.cmd, and cmd.exe cuts that command line at the space ('C:\Program' is not recognized). A junction without spaces, first on the PATH, works around it until lstk passes the JSON another way.
• yq, which the Windows runner image lacks, comes from a pinned release checked against its SHA-256, and the Azure SQL Database app gets the Go sqlcmd release, pinned the same way. psql, which the image installs off the PATH, goes on it for the PostgreSQL and App Configuration apps.

Tests

• actionlint with shellcheck on the workflow and on each bash step, and the repository's pre-commit hooks (zizmor, gitleaks).
• The first manual runs stopped before any app ran and found two Windows problems, now fixed: the Docker daemon the package started and the lstk cloud registration above.
• The first full run reached every app's deployment and found two more problems: psql off the PATH (fixed here) and curl's -o /dev/null, which stopped the end-to-end test with exit code 23 (fixed in Run the scripts from Git Bash and MSYS2 on Windows #47).
• This manual run runs every app with all of them fixed.

Related

• localstack-azure-samples gets the same job: Run all samples on a Windows runner from Git Bash localstack/localstack-azure-samples#142

🤖 Generated with Claude Code

https://claude.ai/code/session_01DhZ2ojsEXd2SGMo7s9uiZh

[Copilot]

🟡 Changes recommended

Missing PostgreSQL client setup and incompatible curl output handling prevent the Windows matrix from completing its intended checks.

2 open issues

• Install native Windows PostgreSQL client before deployment · New
• Use Windows-safe curl output handling in vacation planner test · New

What changed in this PR

Adds on-demand Windows coverage for the AKS samples, exercising deployment and end-to-end checks from Git Bash alongside the existing Linux workflow.

Changes:

• Adds a manual windows input that selects every sample and skips the Linux matrix.
• Runs the emulator through Docker Engine in WSL 2, with Windows-side tooling and an Azure CLI path workaround.
• Reuses cluster creation, sample deployment, tests, and failure diagnostics on Windows.

File	Description
.github/​workflows/​samples.yml	Adds Windows job selection, environment setup, and sample validation.

_{Review effort: Balanced}