Skip to content

DM-56308: updated DP2 NB 306 1 and new 306 2 (extragal transients) - #220

Open
MelissaGraham wants to merge 1 commit into
mainfrom
tickets/DM-56308
Open

MelissaGraham wants to merge 1 commit into
mainfrom
tickets/DM-56308

Conversation

@MelissaGraham

Copy link
Copy Markdown
Contributor

No description provided.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -22,7 +22,7 @@
"Data Release: [Data Preview 2](https://dp2.lsst.io/)\\\n",

@shenmingfu shenmingfu Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forced photometry on the science/visit image for the light curve?


Reply via ReviewNB

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: emphasize that fluxes should be used with difference-image measurements (do it in boldface like the other important points).

@@ -22,7 +22,7 @@
"Data Release: [Data Preview 2](https://dp2.lsst.io/)\\\n",

@shenmingfu shenmingfu Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: is it doing a nearest neighbor search?


Reply via ReviewNB

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: specify this is not nearest-neighbor, this will return all sources within the radius so multiple matches are possible. It's why the 2" gets used here, to demonstrate this, so make it clearer for the user.

@@ -22,7 +22,7 @@
"Data Release: [Data Preview 2](https://dp2.lsst.io/)\\\n",

@shenmingfu shenmingfu Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps mention that the cases when flux <=0 can be filtered out from the analysis, if the magnitude is needed (from forced photometry on the science image).


Reply via ReviewNB

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: mention again that in the future, with no template contamination, transient fluxes should all be >0 in the difference image, and so being careful to retain flux<0 data points is a DP2-specific issue, because of how templates are made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants