Skip to content

docs(refactoring): propose step 10d, keep E2 on hold for upstream #3753 - #42

Merged
marcelverdult merged 1 commit into
integrationfrom
docs/10d-proposal-e2-status
Nov 4, 2026
Merged

marcelverdult merged 1 commit into
integrationfrom
docs/10d-proposal-e2-status

Conversation

@marcelverdult

Copy link
Copy Markdown
Owner

Docs only, no code.

  • 0010: new section "Step 10d" as a proposal. A known command whose frame is shorter than its minimum would answer ILLEGAL_ARG (6) instead of UNSUPPORTED_CMD (1), as docs/companion_protocol.md already documents for a bad length. Unknown codes and handlers that return false keep code 1. Client check of meshcore.js 1.15.0, meshcore_py, meshcore-cli and KiekR: none relies on code 1 for a short frame; the one detection through code 1 (meshcore-cli set_flood_scope) always sends at least the minimum. The Android/iOS apps and the web client were not checked.
  • 0010: the number of codes whose short frame answers UNSUPPORTED_CMD is 43 (the rows of the inventory), not 54.
  • 0011: Refactor GPS management out of EnvironmentSensorManager into LocationProvider hierarchy meshcore-dev/MeshCore#1799 was closed on 01.11.2026 without a merge. The GPS code is being reworked in Big GPS refactor meshcore-dev/MeshCore#3753 (89 files, 65 under variants/, new GpsDriver classes and CommonGpsPrefs), so E2 stays not built until Big GPS refactor meshcore-dev/MeshCore#3753 is merged or closed.

…hcore-dev#3753

0010: step 10d as a proposal (a too short frame answers ILLEGAL_ARG, as
docs/companion_protocol.md already documents), with the client check of
meshcore.js, meshcore_py, meshcore-cli and KiekR. The count of codes whose
short frame answers UNSUPPORTED_CMD is 43, as the inventory lists, not 54.

0011: meshcore-dev#1799 was closed without a merge; the GPS code is being reworked in
meshcore-dev#3753, so E2 stays not built.
@marcelverdult
marcelverdult merged commit 9f6936c into integration Nov 4, 2026
1 check passed
@marcelverdult
marcelverdult deleted the docs/10d-proposal-e2-status branch November 4, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant