Repository navigation
Adjust cached client fixtures for device-detector 6.5.2 [no_release] - #99
Merged
Merged
Conversation
Cached browser results always contain the engine, and client hints now provide the engine as well.
sgiehl
force-pushed
the
composer-update
branch
from
October 21, 2026 06:54
a03cba8 to
e41a083
Compare
AltamashShaikh
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test update for matomo-org/matomo#25548, which updates
matomo/device-detectorfrom 6.5.1 to 6.5.2.In 6.5.2,
Browser::parse()reads theenginekey from the user-agent result when client hints are present.CachedBrowserParserreturns the cached client as that result, but the fixtures inDeviceDetectorCacheFactoryTestandCachedEntryTestused cached clients without an engine, so both tests failed withUndefined array key "engine". Real cache entries always contain it, becausewriteToCache()storesgetClient().The fixtures now include the engine. Since 6.5.2 also takes the engine from client hints, the expected client is now
Blink/98.0, the same as uncached detection returns for that user agent and those client hints.Only tests change; there is no code change in this plugin.
plugins/DeviceDetectorCachein the core PR points at this branch.Checklist