Repository navigation
Add regression cases for union alias display - #5454
Closed
asukaminato0721 wants to merge 1 commit into
Closed
asukaminato0721 wants to merge 1 commit into
asukaminato0721 wants to merge 1 commit into
Conversation
Record inferred decorator returns, repeated union composition, generic collapse, and imported alias identity before changing presentation. Check nested named and anonymous unions have the same linear visitor growth.
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D128365598. (Because this pull request was imported automatically, there will not be any future comments.) |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
stroxler
approved these changes
Oct 29, 2026
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
This pull request has been merged in 12064f9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Record regression cases before replacing the union display changes in #2466. Related to #1115.
The tests cover an unannotated decorator, an annotated alias combined with another type, repeated union composition, generic substitution that collapses to the alias, and a shared alias imported through two modules.
Test checks named and anonymous unions through twenty nested tuple levels. Each must visit
5 * depth + 1Type nodes. This detects the exponential display-payload duplication reported in the old review.This PR contains tests only. The repeated-composition test marks the existing loss of the alias name as a known display bug. Its semantic
assert_typechecks that no union members disappear.Test Plan
The following checks passed on Linux:
The nested traversal test checks named and anonymous unions through twenty levels. Both visit
5 * depth + 1type nodes.