Repository navigation
Conversation
The Make and Meson builds add the x86_64 Huffman decoder assembly source to every build, whatever the target CPU. Match the CMake build and only build it when targeting x86_64, otherwise explicitly disable assembly. For Make, ask the compiler whether it targets x86_64, rather than using uname, so cross-compiling and -m32 builds are handled. For Meson, check the host machine's CPU family.
Now that the build systems only build the assembly source when targeting x86_64, remove the aarch64 BTI/PAC GNU property note which only existed for the empty object built on aarch64. While here, #undef the DECODE_AND_GET_NEXT macro instead of the not yet defined DECODE.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The Make and Meson builds add the x86_64 Huffman decoder assembly
source to every build, whatever the target CPU. Match the CMake build
and only build it when targeting x86_64, otherwise explicitly disable
assembly.
For Make, ask the compiler whether it targets x86_64, rather than
using uname, so cross-compiling and -m32 builds are handled. For
Meson, check the host machine's CPU family.
Checklist
A gain in one configuration is not a general gain: see the Performance section of CONTRIBUTING.md.
Tools used
AI usage: I took a look at the 3 build systems to assess the situation. Claude Opus figured out
the Meson and GNU Make bits for the architecture checks.