Repository navigation
fix(serialization-text): write zero int, float and timedelta values - #804
Merged
Vincent Biret (baywet) merged 1 commit intoOct 15, 2026
Merged
Conversation
write_int_value, write_float_value and write_timedelta_value skipped falsy values, so 0, 0.0 and timedelta(0) wrote nothing and get_serialized_content raised "No content was written". Check for None instead, as the JSON and form writers do.
|
Vincent Biret (baywet)
approved these changes
Oct 15, 2026
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
TextSerializationWriter.write_int_value,write_float_valueandwrite_timedelta_valueskip falsy values, so0,0.0andtimedelta(0)write nothing andget_serialized_content()raisesNo content was written to the serialization writer. The JSON and form writers both write zero. This checks forNoneinstead.Related Issue
None, found while reading the text writer.
Testing Instructions
cd packages/serialization/text && pytesttest_write_zero_values(int 0, float 0.0, timedelta(0)) fails on main with the "No content was written" exception and passes with this change.