Repository navigation
Fix line offsets when incremental edits join CRLF - #1882
Open
ammann (agammann) wants to merge 1 commit into
Open
ammann (agammann) wants to merge 1 commit into
ammann (agammann) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
An incremental edit can join a carriage return and line feed across the edit boundary while leaving the cached line offsets stale. For example, inserting
\nat line 1, character 0 ina\rbproducesa\r\nb, butlineCountreturns 3 instead of 2. Line and position lookups then disagree with a fresh document containing the same text.Fix
Invalidate cached line offsets when an edit leaves a CRLF pair across either edit boundary. The next lookup rebuilds them from the updated content; other edits retain the incremental update path.
Verification
b4f995b(3 !== 2) and passes with this fix. It covers insertion at either side of the boundary, removal of an intervening character, and a batch of edits.textDocument:npm run all(63 tests passing).npm run symlink,npm run compile,npm run lint, andnpm testpassed locally on Node 22.PLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-x64.