Repository navigation
Report workspace/diagnostic as the failed request in workspace pulls - #1915
Open
Trivikram Kamat (trivikr) wants to merge 1 commit into
Open
Trivikram Kamat (trivikr) wants to merge 1 commit into
Trivikram Kamat (trivikr) wants to merge 1 commit into
Conversation
The error handler for workspace diagnostic pulls passed DocumentDiagnosticRequest.type to handleFailedRequest. A failed pull was therefore logged and shown as "Request textDocument/diagnostic failed." Pass WorkspaceDiagnosticRequest.type so the log and notification name the request that was actually sent.
There was a problem hiding this comment.
🟢 Approval recommended
The one-line correction matches the outgoing request and fixes error labeling without changing other error-handling behavior.
No open issues 🎉
What changed in this PR
Corrects failure reporting for workspace diagnostic pulls so errors identify the request that was actually sent.
Changes:
- Passes
WorkspaceDiagnosticRequest.typeto the failure handler instead ofDocumentDiagnosticRequest.type, preserving existing cancellation and fallback behavior.
| File | Description |
|---|---|
client/src/common/diagnostic.ts |
Corrects the request type used to report workspace diagnostic failures. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error handler for workspace diagnostic pulls passed
DocumentDiagnosticRequest.typeto handleFailedRequest. A failed pull was therefore logged and shown as "Request textDocument/diagnostic failed."Pass
WorkspaceDiagnosticRequest.typeso the log and notification name the request that was actually sent.