Repository navigation
seccomp: fix nativeToSeccomp keys for loong64 and mipsle - #53
Merged
thaJeztah merged 1 commit intoOct 12, 2026
Merged
Conversation
setupSeccomp looks up goToNative[runtime.GOARCH] in nativeToSeccomp
to pick the archMap entry. For loong64 and mipsle the goToNative
values ("loongarch64", "mipsel") had no matching nativeToSeccomp key
("loong64", "mipsle"), so the lookup failed and Architectures was
not populated on those platforms.
Rename the two nativeToSeccomp keys to match, and add a test that
every goToNative value has a nativeToSeccomp entry.
Fixes moby#52
Signed-off-by: Ricardo Branco <rbranco@suse.de>
Member
|
Looks like these were added in 8a31106 cc @yzewei And the mipsel originates from much older; e3065b7 (moby/moby@ccbb00c815); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setupSeccomp looks up goToNative[runtime.GOARCH] in nativeToSeccomp to pick the archMap entry. For loong64 and mipsle the goToNative values ("loongarch64", "mipsel") had no matching nativeToSeccomp key ("loong64", "mipsle"), so the lookup failed and Architectures was not populated on those platforms.
Rename the two nativeToSeccomp keys to match, and add a test that every goToNative value has a nativeToSeccomp entry.
Fixes #52