Repository navigation
[Docs] Fix examples that don't stand alone and drop stale release info - #555
Merged
Merged
Conversation
…stale release info
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 7, 2026 23:11
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several examples remain nonfunctional due to an undefined request, missing import, absent callback return, and unadvertised capability.
4 open findings
What changed in this PR
Updates documentation examples and removes time-sensitive release details.
Changes:
- Adds missing imports and request setup to examples.
- Replaces deprecated client features with elicitation.
- Clarifies that conformance figures came from an audit.
| File | Description |
|---|---|
docs/sdk-tier.md |
Makes audit and release status wording less stale. |
docs/run/protocol-eras.md |
Adds dependencies and request initialization. |
docs/client/server-requests.md |
Uses a PSR-3 logger. |
docs/client/errors.md |
Replaces sampling with elicitation. |
docs/client/connecting.md |
Updates capabilities and handlers to elicitation. |
docs/advanced/extensions.md |
Adds the missing content class import. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation changes are accurate, internally consistent, and address the stated stale and incomplete examples.
0 open findings
4 resolved since last review
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


$requestin the protocol eras examples, missingTextResourceContentsimport in the extensions examplelogger()replaced with a PSR-3 logger in the client logging examplesetLoggingLevel()