Skip to content

[Docs] Fix examples that don't stand alone and drop stale release info - #555

Merged
chr-hertel merged 2 commits into
modelcontextprotocol:mainfrom
chr-hertel:docs-examples
Oct 8, 2026
Merged

chr-hertel merged 2 commits into
modelcontextprotocol:mainfrom
chr-hertel:docs-examples

Conversation

@chr-hertel

Copy link
Copy Markdown
Member
  • Missing imports and $request in the protocol eras examples, missing TextResourceContents import in the extensions example
  • Laravel's logger() replaced with a PSR-3 logger in the client logging example
  • Client examples in connecting & errors use elicitation instead of the deprecated sampling, roots and setLoggingLevel()
  • SDK tier page no longer hard-codes the latest release, conformance numbers are marked as the audit's

@chr-hertel
chr-hertel requested a balanced review from Copilot October 7, 2026 23:12
@chr-hertel chr-hertel added bug Something isn't working documentation Improvements or additions to documentation labels Oct 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Several examples remain nonfunctional due to an undefined request, missing import, absent callback return, and unadvertised capability.

4 open findings
What changed in this PR

Updates documentation examples and removes time-sensitive release details.

Changes:

  • Adds missing imports and request setup to examples.
  • Replaces deprecated client features with elicitation.
  • Clarifies that conformance figures came from an audit.
File Description
docs/​sdk-tier.md Makes audit and release status wording less stale.
docs/​run/​protocol-eras.md Adds dependencies and request initialization.
docs/​client/​server-requests.md Uses a PSR-3 logger.
docs/​client/​errors.md Replaces sampling with elicitation.
docs/​client/​connecting.md Updates capabilities and handlers to elicitation.
docs/​advanced/​extensions.md Adds the missing content class import.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/client/connecting.md
Comment thread docs/client/connecting.md
Comment thread docs/client/server-requests.md
Comment thread docs/run/protocol-eras.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation changes are accurate, internally consistent, and address the stated stale and incomplete examples.

0 open findings

4 resolved since last review

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@chr-hertel
chr-hertel merged commit b648df0 into modelcontextprotocol:main Oct 8, 2026
28 checks passed
@chr-hertel
chr-hertel deleted the docs-examples branch October 8, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants