Repository navigation
Conversation
…File CellBudgetFile matched the text and paknam/paknam2 arguments as substrings and took the first name in the file containing them. With MF6, text="RCH" could therefore resolve to RCHA (array-based recharge) or UZF-GWRCH if either appeared in the file first, silently dropping the list-based RCH records. Likewise paknam2="rch_1" could resolve to RCH_10. Prefer an exact (case- and whitespace-insensitive) match, falling back to the previous substring matching if there is none, so abbreviations like "spdis" still work. Apply the same rule in export(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2891 +/- ##
===========================================
+ Coverage 55.5% 72.0% +16.5%
===========================================
Files 644 659 +15
Lines 124135 132494 +8359
===========================================
+ Hits 68947 95500 +26553
+ Misses 55188 36994 -18194
🚀 New features to boost your workflow:
|
wpbonelli
marked this pull request as ready for review
November 16, 2026 21:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CellBudgetFilemethods currently matchtextandpaknam/paknam2arguments as substrings and unconditionally take the first match. This means e.g.text="RCH"could return an RCHA package if it appeared in the file first. Likewisepaknam2="rch_1"could return a package named "RCH_10". This is true of the following methods:get_data()get_indices()get_ts()export()While this is fairly long-standing and could now be considered expected behavior, I think it's best called a bug, since
I think it is more correct to prefer exact (case- and whitespace-insensitive) matches, falling back to the substring match if there is no exact match. This means abbreviations continue to work.
This has the following consequences.
text/paknamquery exactly matches a record name, that record is now selected even if another name containing the query appears earlier in the file. For example,text="rch"in a model with both RCHA and RCH packages previously returned the RCHA record; it now returns the RCH record(s).export(text=...)will export only the exactly matching record when one exists, rather than every record whose name contains the query. Queries with no exact match keep the previous substring behavior.