Repository navigation
docs(drafts): trim moq-lite-07 routing text and group its changelog - #7196
Conversation
Drop the local link preference from the route tie-break chain, since it is never on the wire, and point to draft-lcurley-moq-cluster for the standby Route Cost bounds instead of repeating them. Group the lite-07 changelog by area and fold follow-up refinements into the entry they refine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the documentation changes: removing routing text and reorganizing the moq-lite-07 changelog. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description check | |
The pull request description directly explains the routing tie-break change and the changelog reorganization described in the changeset. |
Finishing Touches
-
Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: cdb1e94
No actionable documentation or protocol-consistency bugs found. Keeping local link preference out of the recommended wire-draft tie-break chain is a coherent simplification; the mandatory split-horizon exclusion remains unchanged. The cluster draft retains the full standby admission/cost bounds and exceptions referenced here.
Compared the regrouped changelog against the base: SETUP count bounds, AUTH ordering/error rules, direct-announcement Spread Hash exception and unchecked timestamp provenance are preserved in their merged entries. No unintended loss of meaning found.
Verification: static diff/context review with an independent routing and changelog pass. I did not build/render the drafts or run tests/interoperability checks.
…ngelog Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Landing summaryMerged main (no rebase) at d9040c7 to resolve the conflict with moq-dev/moq#6951 (lite-07 SUBSCRIBE_OK names where each range starts). Resolution
Hand check against main, bullet by bullet over the lite-07 changelog (66 bullets on main, 62 here) plus a full-file diff:
Checks: Review: Codex's review is stuck, so in a (Written by Opus 5.5) |
# Conflicts: # drafts/draft-lcurley-moq-lite.md
|
Landing summary: merged main to resolve the changelog conflict with moq-dev/moq#7037. Its new (Written by Opus 5.5) |
|
quest land removed this pull request from the queue: the repository's check failed with it alone on the base; fix it and land it again (run). |
|
quest land removed this pull request from the queue: Conflicts with the base: drafts/draft-lcurley-moq-lite.md |
|
quest land removed this pull request from the queue: the batch check failed (exit 1). Checking moq-msf...
Checking moq-mux...
Checking moq-native...
Checking moq-net...
Checking moq-net-tests...
Checking moq-nvenc...
Checking moq-pattern...
Checking moq-quic...
Checking moq-relay...
Checking moq-room...
Checking moq-rtc...
Checking moq-rtmp...
Checking moq-rtsp...
Checking moq-scene...
Checking moq-shaper...
Checking moq-sign...
Checking moq-sock...
Checking moq-srt...
Checking moq-stats...
Checking moq-studio...
Checking moq-tokio...
Checking moq-transcode...
Checking moq-uring...
Checking moq-v4l...
Checking moq-video...
Checking qmux...
Checking test-env...
Checking uniffi-bindgen...
Checking macros...
Checking macros...
Checking fuzz...
Checking fuzz...
==> test rs
sh/rs/select.sh test "$LIST"
rs: selecting bridge hang moq-archive moq-audio moq-bench moq-boy moq-c moq-cli moq-e2ee moq-ffi moq-gst moq-hls moq-json moq-loc moq-mux moq-net moq-net-tests moq-relay moq-room moq-rtc moq-rtmp moq-rtsp moq-scene moq-sign moq-srt moq-stats moq-studio moq-tokio moq-transcode moq-uring moq-video qmux
rs: selecting bridge hang moq-archive moq-audio moq-bench moq-boy moq-c moq-cli moq-e2ee moq-ffi moq-gst moq-hls moq-json moq-loc moq-mux moq-net moq-net-tests moq-relay moq-room moq-rtc moq-rtmp moq-rtsp moq-scene moq-sign moq-srt moq-stats moq-studio moq-tokio moq-transcode moq-uring moq-video qmux
CARGO_BUILD_WARNINGS=deny RUSTC_WORKSPACE_WRAPPER='/nix/store/4klbl675argl2irhl89zrh2n14wilzx9-rust-minimal-1.98.1/bin/clippy-driver' bash sh/rs/nextest.sh cargo nextest run --locked --tests "$@"
Compiling kio-macros v0.1.0 (/work/rs/kio/macros)
Compiling moq-clock-macros v0.1.0 (/work/rs/moq-clock/macros)
Compiling moq-pattern v0.1.2 (/work/rs/moq-pattern)
Compiling moq-sock v0.2.0 (/work/rs/moq-sock)
Compiling moq-msf v0.5.1 (/work/rs/moq-msf)
Compiling kio v0.6.2 (/work/rs/kio)
Compiling bench-harness v0.0.1 (/work/rs/bench-harness)
Compiling moq-clock v0.11.0 (/work/rs/moq-clock)
Compiling moq-video v0.1.10 (/work/rs/moq-video)
Compiling moq-net v0.3.10 (/work/rs/moq-net)
Compiling moq-congestion v0.1.0 (/work/rs/moq-congestion)
Compiling moq-ice v0.1.0 (/work/rs/moq-ice)
Compiling moq-nvenc v0.1.2 (/work/rs/moq-nvenc)
Compiling moq-quic v0.1.0 (/work/rs/moq-quic)
Compiling moq-v4l v0.1.0 (/work/rs/moq-v4l)
Compiling test-env v0.0.1 (/work/rs/test-env)
Compiling moq-auth v0.2.1 (/work/rs/moq-auth)
Compiling moq-shaper v0.0.1 (/work/rs/moq-shaper)
Compiling moq-gst v0.4.12 (/work/rs/moq-gst)
Compiling moq-c v0.7.0 (/work/rs/moq-c)
Compiling moq-json v0.5.8 (/work/rs/moq-json)
Compiling moq-loc v0.2.19 (/work/rs/moq-loc)
Compiling qmux v0.7.0 (/work/rs/qmux)
Compiling moq-uring v0.0.12 (/work/rs/moq-uring)
Compiling moq-archive v0.0.11 (/work/rs/moq-archive)
Compiling moq-e2ee v0.0.11 (/work/rs/moq-e2ee)
Compiling hang v0.21.11 (/work/rs/hang)
Compiling moq-stats v0.2.12 (/work/rs/moq-stats)
Compiling moq-tokio v0.19.23 (/work/rs/moq-tokio)
Compiling moq-mux v0.10.11 (/work/rs/moq-mux)
Compiling moq-net-tests v0.0.0 (/work/rs/moq-net-tests)
Compiling moq-sign v0.0.1 (/work/rs/moq-sign)
Compiling moq-audio v0.1.10 (/work/rs/moq-audio)
Compiling moq-hls v0.5.11 (/work/rs/moq-hls)
Compiling moq-relay v0.17.2 (/work/rs/moq-relay)
Compiling moq-rtsp v0.1.0 (/work/rs/moq-rtsp)
Compiling moq-rtc v0.3.12 (/work/rs/moq-rtc)
Compiling moq-rtmp v0.3.11 (/work/rs/moq-rtmp)
Compiling moq-srt v0.3.11 (/work/rs/moq-srt)
Compiling moq-scene v0.1.0 (/work/rs/moq-scene)
Compiling moq-carla-bridge v0.1.0 (/work/demo/carla/bridge)
Compiling moq-cli v0.14.2 (/work/rs/moq-cli)
Compiling moq-studio v0.1.0 (/work/rs/moq-studio)
Compiling moq-ffi v0.4.12 (/work/rs/moq-ffi)
Compiling moq-transcode v0.1.10 (/work/rs/moq-transcode)
Compiling moq-bench v0.0.1 (/work/rs/moq-bench)
Compiling moq-room v0.2.11 (/work/rs/moq-room)
error: recipe `test-changed` failed on line 82 with exit code 143
ci: test js failed
ci: seconds per module
77 check rs
251 test rs (cancelled)
278 check js
49 test js (failed)
0 check drill
2 check quest
17 check shell
0 check large_files
1 check toml
0 check nix
0 check justfile
329 wall time
error: recipe `ci` failed on line 107 with exit code 1
. |
|
codex / Codex land fixer: (written by codex / Codex) |
|
quest land removed this pull request from the queue: Conflicts with the base: drafts/draft-lcurley-moq-lite.md |
|
quest land removed this pull request from the queue: the batch check failed (exit 101). @moq/net:build | ✍️ Rewriting package.json...
@moq/net:build | 🔗 Converted @moq/clock: workspace:^ → ^0.1.0
@moq/net:build | 🔗 Converted @moq/pattern: workspace:^ → ^0.2.1
@moq/net:build | 🔗 Converted @moq/qmux: workspace:^ → ^0.3.3
@moq/net:build | 🔗 Converted @moq/signals: workspace:* → ^0.2.5
@moq/net:build | 🏷️ Stamping version 0.4.2...
@moq/net:build | 📄 Copying README.md...
@moq/net:build | 🔍 Running publint...
@moq/net:build | 📦 Package built successfully in dist/
@moq/net:build | ✍️ Generating jsr.json...
@moq/net:build | 📦 jsr.json written
@moq/net:build | Done in 4.49s
@moq/p2p:build | ✍️ Rewriting package.json...
@moq/p2p:build | 🔗 Converted @moq/qmux: workspace:^ → ^0.3.3
@moq/p2p:build | 📄 Copying README.md...
@moq/p2p:build | 🔍 Running publint...
@moq/p2p:build | 📦 Package built successfully in dist/
@moq/p2p:build | Done in 452ms
@moq/pattern:build | ✍️ Rewriting package.json...
@moq/pattern:build | 📄 Copying README.md...
@moq/pattern:build | 🔍 Running publint...
@moq/pattern:build | 📦 Package built successfully in dist/
@moq/pattern:build | ✍️ Generating jsr.json...
@moq/pattern:build | 📦 jsr.json written
@moq/pattern:build | Done in 481ms
@moq/publish:build | �[36mvite v8.3.4 �[32mbuilding client environment for production...�[36m�[39m
@moq/publish:build | transforming...
@moq/publish:build | ✓ 136 modules transformed.
@moq/publish:build | rendering chunks...
@moq/publish:build | computing gzip size...
@moq/publish:build | dist/assets/capture-worker.js 0.64 kB
@moq/publish:build | dist/assets/capture-worklet.js 1.37 kB
@moq/publish:build | dist/capture-worker-BJ0xkcGF.js 0.81 kB │ gzip: 0.50 kB │ map: 1.00 kB
@moq/publish:build | dist/index.js 1.06 kB │ gzip: 0.54 kB │ map: 1.57 kB
@moq/publish:build | dist/support/index.js 1.16 kB │ gzip: 0.65 kB │ map: 4.26 kB
@moq/publish:build | dist/support/element.js 1.36 kB │ gzip: 0.54 kB │ map: 3.20 kB
@moq/publish:build | dist/capture-worklet-CRiEEPvQ.js 1.54 kB │ gzip: 0.70 kB │ map: 1.74 kB
@moq/publish:build | dist/video-CKv257p3.js 4.83 kB │ gzip: 1.94 kB │ map: 19.44 kB
@moq/publish:build | dist/microphone-BIV2nutQ.js 8.09 kB │ gzip: 2.43 kB │ map: 35.77 kB
@moq/publish:build | dist/element.js 10.88 kB │ gzip: 3.19 kB │ map: 40.35 kB
@moq/publish:build | dist/ui/element.js 31.00 kB │ gzip: 7.87 kB │ map: 47.32 kB
@moq/publish:build | dist/encoder-CCfPI81c.js 60.82 kB │ gzip: 17.89 kB │ map: 284.54 kB
@moq/publish:build | dist/src-B72dZGl2.js 483.22 kB │ gzip: 111.10 kB │ map: 1,872.47 kB
@moq/publish:build |
@moq/publish:build | �[32m✓ built in 257ms�[39m
@moq/publish:build | ✍️ Rewriting package.json...
@moq/publish:build | 🔗 Converted @moq/clock: workspace:^ → ^0.1.0
@moq/publish:build | 🔗 Converted @moq/hang: workspace:^ → ^0.5.2
@moq/publish:build | 🔗 Converted @moq/json: workspace:^ → ^0.4.2
@moq/publish:build | 🔗 Converted @moq/net: workspace:^ → ^0.4.2
@moq/publish:build | 🔗 Converted @moq/signals: workspace:^ → ^0.2.5
@moq/publish:build | 🔗 Converted @moq/ui: workspace:^ → ^0.1.0
@moq/publish:build | 🔗 Converted @moq/video: workspace:^ → ^0.1.0
@moq/publish:build | 📄 Copying README.md...
@moq/publish:build | 🔍 Running publint...
@moq/publish:build | 📦 Package built successfully in dist/
@moq/publish:build | Done in 2.02s
@moq/qmux:build | ✍️ Rewriting package.json...
@moq/qmux:build | 🔗 Converted @moq/clock: workspace:^ → ^0.1.0
@moq/qmux:build | 📄 Copying README.md...
@moq/qmux:build | 🔍 Running publint...
@moq/qmux:build | 📦 Package built successfully in dist/
@moq/qmux:build | ✍️ Generating jsr.json...
@moq/qmux:build | 📦 jsr.json written
@moq/qmux:build | Done in 1.66s
@moq/room:build | ✍️ Rewriting package.json...
@moq/room:build | 🔗 Converted @moq/clock: workspace:^ → ^0.1.0
@moq/room:build | 🔗 Converted @moq/hang: workspace:^ → ^0.5.2
@moq/room:build | 🔗 Converted @moq/json: workspace:^ → ^0.4.2
@moq/room:build | 🔗 Converted @moq/net: workspace:^ → ^0.4.2
@moq/room:build | 🔗 Converted @moq/publish: workspace:^ → ^0.5.2
@moq/room:build | 🔗 Converted @moq/signals: workspace:^ → ^0.2.5
@moq/room:build | 🔗 Converted @moq/watch: workspace:^ → ^0.6.2
@moq/room:build | 📄 Copying README.md...
@moq/room:build | 🔍 Running publint...
@moq/room:build | 📦 Package built successfully in dist/
@moq/room:build | ✍️ Generating jsr.json...
@moq/room:build | 📦 jsr.json written
@moq/room:build | Done in 1.48s
@moq/sign:build | ✍️ Rewriting package.json...
@moq/sign:build | 🔗 Converted @moq/net: workspace:^ → ^0.4.2
@moq/sign:build | 📄 Copying README.md...
@moq/sign:build | 🔍 Running publint...
@moq/sign:build | 📦 Package built successfully in dist/
@moq/sign:build | Done in 695ms
error: recipe `check-changed` failed on line 31 with exit code 143
ci: test rs failed
ci: seconds per module
65 check rs
100 test rs (failed)
165 check js (cancelled)
0 check drill
2 check quest
19 check shell
1 check large_files
0 check toml
0 check nix
0 check justfile
166 wall time
error: recipe `ci` failed on line 107 with exit code 101
. |
|
codex / Codex land fixer: (written by codex / Codex) |
Problem
The moq-lite-07 draft had grown to about 65 changelog entries in roughly chronological order, with follow-up fixes listed apart from the feature they refine. Its route selection rule also contained a local link preference in the normative tie-break chain. It is never carried on the wire, so it cannot affect interop.
Approach
origin::Producer::with_preference.\escape changelog entry and placed it under Paths and Routing, beside the empty-segment entry.test rs, which this draft-only PR does not touch. Merging main again was conflict-free and changed no draft text.Impact
Alternatives
Review
Codex (
quest review), gpt-6.1-sol, medium effort, on head a2b740d (merge of main at 4b8e37b, no draft changes from main): no findings.CodeRabbit's suggestion to add a "Removed the arriving-link preference" changelog entry was declined: the preference was added during lite-07 and never existed in lite-06, so removing it along with its own "Added" entry is no change against lite-06.
Follow-ups
None.
🤖 Generated with Claude Code
(Written by Opus 5.5)