Repository navigation
feat(settings): warn when PHP-FPM reaches pm.max_children - #46570
Open
joshtrichards wants to merge 3 commits into
Open
joshtrichards wants to merge 3 commits into
joshtrichards wants to merge 3 commits into
Conversation
joshtrichards
force-pushed
the
feat-setupcheck-php-sapi-fpm-max-children
branch
2 times, most recently
from
July 18, 2024 15:55
b8594e2 to
a6626d6
Compare
Member
|
@joshtrichards what is missing here? Can I help move this forward? :) |
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
feat-setupcheck-php-sapi-fpm-max-children
branch
from
October 31, 2026 14:35
a6626d6 to
16f8287
Compare
Report when PHP-FPM reaches its configured pm.max_children limit, including the peak active process count and pool restart time. Handle unavailable or incomplete FPM status with a warning, and link admins to the PHP-FPM documentation for troubleshooting guidance. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
marked this pull request as ready for review
October 31, 2026 16:24
joshtrichards
requested review from
icewind1991
and removed request for
a team
October 31, 2026 16:24
joshtrichards
requested review from
CarlSchwan,
kesselb,
leftybournes and
salmart-dev
October 31, 2026 16:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a PHP setup check that warns when the PHP-FPM pool has reached its configured
pm.max_childrenlimit. Since this can cause various problems, let's give a hint to the admin.Include the number of occurrences, latest restart time, and peak active process count to help admins assess the impact.
The check is not applicable to non-FPM SAPIs, including
mod_php. PHP provides no direct equivalent for retrievingmod_phpstatus; using Apache’smod_statuswould require additional server configuration.If PHP-FPM status is unavailable or incomplete, report that the check could not be completed. Link to the PHP-FPM documentation and advise reviewing pool configuration and server capacity before increasing the limit.
TODO
Checklist