Skip to content

feat(settings): warn when PHP-FPM reaches pm.max_children - #46570

Open
joshtrichards wants to merge 3 commits into
masterfrom
feat-setupcheck-php-sapi-fpm-max-children
Open

joshtrichards wants to merge 3 commits into
masterfrom
feat-setupcheck-php-sapi-fpm-max-children

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Jul 16, 2024 •

Copy link
Copy Markdown
Member

Summary

Add a PHP setup check that warns when the PHP-FPM pool has reached its configured pm.max_children limit. Since this can cause various problems, let's give a hint to the admin.

Include the number of occurrences, latest restart time, and peak active process count to help admins assess the impact.

The check is not applicable to non-FPM SAPIs, including mod_php. PHP provides no direct equivalent for retrieving mod_php status; using Apache’s mod_status would require additional server configuration.

If PHP-FPM status is unavailable or incomplete, report that the check could not be completed. Link to the PHP-FPM documentation and advise reviewing pool configuration and server capacity before increasing the limit.

TODO

Checklist

@joshtrichards joshtrichards added the pending documentation This pull request needs an associated documentation update label Jul 16, 2024
@joshtrichards
joshtrichards force-pushed the feat-setupcheck-php-sapi-fpm-max-children branch 2 times, most recently from b8594e2 to a6626d6 Compare July 18, 2024 15:55
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@skjnldsv

skjnldsv commented Dec 3, 2024

Copy link
Copy Markdown
Member

@joshtrichards what is missing here? Can I help move this forward? :)
That looks like a nice idea!

@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@blizzz blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026
@susnux susnux added the community pull requests from community label Jun 9, 2026
@susnux susnux removed this from the Nextcloud 34.0.1 milestone Jun 9, 2026
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@joshtrichards
joshtrichards force-pushed the feat-setupcheck-php-sapi-fpm-max-children branch from a6626d6 to 16f8287 Compare October 31, 2026 14:35
Report when PHP-FPM reaches its configured pm.max_children limit, including the peak active process count and pool restart time.

Handle unavailable or incomplete FPM status with a warning, and link admins to the PHP-FPM documentation for troubleshooting guidance.

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards changed the title feat: PHP-FPM setup check / max_children check feat(settings): warn when PHP-FPM reaches pm.max_children Oct 31, 2026
@joshtrichards joshtrichards added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 31, 2026
@joshtrichards
joshtrichards marked this pull request as ready for review October 31, 2026 16:24
@joshtrichards
joshtrichards requested a review from a team as a code owner October 31, 2026 16:24
@joshtrichards
joshtrichards requested review from icewind1991 and removed request for a team October 31, 2026 16:24
@joshtrichards joshtrichards added this to the Nextcloud 36 milestone Oct 31, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews community pull requests from community enhancement feature: settings pending documentation This pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants