Repository navigation
Conversation
Phillipxh
requested review from
leftybournes,
pabzm and
salmart-dev
and removed request for
a team
October 30, 2026 16:49
`occ trashbin:size <size>` stores the default size with setValueInt(),
but Trashbin::getConfiguredTrashbinSize() read it with getValueString().
AppConfig then throws AppConfigTypeConflictException ("stored as integer
but was requested as string") on every write to a user's files and on
every trash bin expiry, so the configured size never takes effect and
the log fills up with errors.
Read it with getValueInt(), which matches the writer and still accepts
values stored without a type by older versions or `occ config:app:set`.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019TNUHUT6jaQ3BHvjvdf4Ny
Signed-off-by: Phillipxh <150742483+Phillipxh@users.noreply.github.com>
Phillipxh
force-pushed
the
fix/trashbin-size-read-as-int
branch
from
October 30, 2026 18:46
4cb747f to
413a77b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
occ trashbin:size <size>stores the default trash bin size withIAppConfig::setValueInt(), butTrashbin::getConfiguredTrashbinSize()read it withgetValueString(). AppConfig then throwsAppConfigTypeConflictException:This happens on every write to a user's files (
resizeTrashvia the post-write listener) and on every trash bin expiry (Command\Expire), so the configured size never takes effect and the log fills up — on my instance ~900 errors in a week after runningocc trashbin:size.The fix reads the value with
getValueInt(), which matches the writer inCommand\Size(which already usesgetValueInt()for display) and still accepts values stored without a type by older versions orocc config:app:set. I checked both cases on a 35.0.1 instance:getValueString()getValueInt()occ trashbin:size)AppConfigTypeConflictExceptionconfig:app:set)'-1'-1The per-user value is unchanged:
Command\Sizewrites it as a string viasetUserValue(), which matches thegetValueString()reader.TODO
Checklist
AI (if applicable)
🤖 Generated with Claude Code
https://claude.ai/code/session_019TNUHUT6jaQ3BHvjvdf4Ny