Repository navigation
fix(dav): handle missing calendar display properties - #66052
Open
joshtrichards wants to merge 6 commits into
Open
joshtrichards wants to merge 6 commits into
joshtrichards wants to merge 6 commits into
Conversation
Return null when calendar metadata omits the optional display name or color properties, matching the nullable ICalendar contract. Signed-off-by: Josh <josh.t.richards@gmail.com>
…tionImpl Align with ICalendar contract Signed-off-by: Josh <josh.t.richards@gmail.com>
…darImpl Align implementation with ICalendar contract Fixes #59587 Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
3. to review
joshtrichards
requested review from
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
October 30, 2026 22:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle missing calendar display metadata consistently with the nullable
ICalendarcontract.Changes:
getDisplayName()andgetDisplayColor()returnnullwhen their metadata keys are absent in regular, cached-subscription, and federated calendars.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)