Repository navigation
[stable34] chore(deps): bump @nextcloud/dialogs from 7.5.0 to 7.6.0 in /build/frontend-legacy - #66092
Conversation
|
@dependabot rebase |
Bumps [@nextcloud/dialogs](https://github.com/nextcloud-libraries/nextcloud-dialogs) from 7.5.0 to 7.6.0. - [Release notes](https://github.com/nextcloud-libraries/nextcloud-dialogs/releases) - [Changelog](https://github.com/nextcloud-libraries/nextcloud-dialogs/blob/main/CHANGELOG.md) - [Commits](nextcloud-libraries/nextcloud-dialogs@v7.5.0...v7.6.0) --- updated-dependencies: - dependency-name: "@nextcloud/dialogs" dependency-version: 7.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
657d591 to
f99498b
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzinger
left a comment
There was a problem hiding this comment.
Requesting changes: @nextcloud/dialogs 7.6.0 deliberately reverts the toast rework from 7.5.0 (nextcloud-libraries/nextcloud-dialogs#2712, "considered a breaking change and moved to v8"). The red Playwright test is the symptom, not the problem.
Why CI fails: tests/playwright/support/utils/toast.ts locates toasts by [role="alert"], [role="status"], which the 7.5.0 toasts set. 7.6.0 goes back to toastify-js, which only sets aria-live and no role, so e.g. files: Drag and Drop › ignores dropped folders (legacy File API) never finds its toast.
What merging would regress:
- The accessible toasts (
role="alert"/role="status") adopted with 7.5.0 are lost again. - The toast functions return a Toastify
Toastagain instead of 7.5.0'sToastHandle.
Adjusting the test helper to also match .toastify would turn this green and ship the regressions above, so please do not merge this as is. The accessible toasts and the timeout configuration are back in @nextcloud/dialogs 8.0.0, which is the way forward on master; stable branches should stay on 7.5.0.
Bumps @nextcloud/dialogs from 7.5.0 to 7.6.0.
Release notes
Sourced from @nextcloud/dialogs's releases.
Changelog
Sourced from @nextcloud/dialogs's changelog.
Commits
d8f29e1Merge pull request #2713 from nextcloud-libraries/chore/release-7.6.0-stable79b35e29Merge pull request #2712 from nextcloud-libraries/revert/stable7-toast-rework96838e0chore: release v7.6.0740c304revert: feat: accessible toast and drop toastify12c4442revert: feat: toast timeout configurationdd5aa80revert: fix(toast): position when closed5a69a39revert: feat(toast): add support for RTL and custom offsetf248ea3Merge pull request #2690 from nextcloud-libraries/perf/file-picker-new-folder...bc258aeMerge pull request #2708 from nextcloud-libraries/translations_441be4f7621043...c9d1303Translate l10n/messages.pot in da