Repository navigation
Should doc-kit import node-core/website-i18n directly #1119
Description
Activity
good question. the blame on that TODO is a year old, and pre-dates our more recent effort to decouple the packages. I know I already approved nodejs/nodejs.org#9180 but similar to ui components, perhaps that is simply a default
Not sure, I know we aren't translating these docs, fwiw
Reacted by Brian Muenzenmeyergood question. the blame on that TODO is a year old, and pre-dates our more recent effort to decouple the packages. I know I already approved nodejs/nodejs.org#9180 but similar to ui components, perhaps that is simply a default
We can update the generator to accept these labels through
getConfig('jsx-ast'), using the English strings as fallback defaults.BTW, I converted that PR to draft, so we can decide here what we will do.
Not sure, I know we aren't translating these docs, fwiw
Yeah, you're right. However, the main goal here is just to avoid having these strings hardcoded in
doc-kit, so we can have a "single source of truth" (fromwebsite-i18n).WDUT, guys? 👀
I added the
i18nlabels in PR atnodejs.org. But I have a question about the TODO inpackages/react.If
doc-kitimports the dictionary fromnodejs.orgdirectly, they will be connected. What if another project usesdoc-kit?