Skip to content

deps: update amaro to 1.3.0 - #66144

Open
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/tools-update-amaro
Open

nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/tools-update-amaro

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Collaborator

This is an automated update of amaro to 1.3.0.

@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. strip-types Issues and PRs related to TypeScript type stripping. labels Sep 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 20, 2026
@codecov

codecov Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.63%. Comparing base (e97c75e) to head (28825fd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66144      +/-   ##
==========================================
- Coverage   90.68%   90.63%   -0.06%     
==========================================
  Files         797      797              
  Lines      278790   278790              
  Branches    53617    53592      -25     
==========================================
- Hits       252834   252676     -158     
- Misses      16303    16476     +173     
+ Partials     9653     9638      -15     

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller

Copy link
Copy Markdown
Member

See #66051

@aduh95

aduh95 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

See #66051

Regardless, it's probably not expected that a semver-minor breaks Node.js

@marco-ippolito

Copy link
Copy Markdown
Member

See #66051

Regardless, it's probably not expected that a semver-minor breaks Node.js

Yes I agree this shouldnt have happened

@nodejs-github-bot nodejs-github-bot changed the title deps: update amaro to 1.2.0 deps: update amaro to 1.2.1 Sep 21, 2026
@nodejs-github-bot
nodejs-github-bot force-pushed the actions/tools-update-amaro branch from 49b3ec8 to 0bcfed5 Compare September 21, 2026 15:36
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Sep 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@panva panva removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 26, 2026
@nodejs-github-bot
nodejs-github-bot force-pushed the actions/tools-update-amaro branch from 8182620 to b36d15a Compare September 27, 2026 01:01
@panva panva removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 27, 2026
@nodejs-github-bot
nodejs-github-bot force-pushed the actions/tools-update-amaro branch 2 times, most recently from 840165f to 9abe615 Compare October 11, 2026 01:04
@nodejs-github-bot
nodejs-github-bot force-pushed the actions/tools-update-amaro branch from 9abe615 to 2ac7755 Compare October 18, 2026 00:54
@nodejs-github-bot nodejs-github-bot changed the title deps: update amaro to 1.2.1 deps: update amaro to 1.2.2 Oct 25, 2026
@nodejs-github-bot
nodejs-github-bot force-pushed the actions/tools-update-amaro branch from 2ac7755 to 6a05d0c Compare October 25, 2026 00:54
@nodejs-github-bot nodejs-github-bot changed the title deps: update amaro to 1.2.2 deps: update amaro to 1.3.0 Nov 1, 2026
@nodejs-github-bot
nodejs-github-bot force-pushed the actions/tools-update-amaro branch from 6a05d0c to 28825fd Compare November 1, 2026 00:40
@GeoffreyBooth

Copy link
Copy Markdown
Member

What's the status of this? Can it land?

@kdy1 kdy1 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to go.


For context,

The biggest change here is nodejs/amaro#467, where amaro now uses the published version of SWC core and self-maintains features related to Node.js

@marco-ippolito

marco-ippolito commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

The CI is red because now the require needs to be updated from index.js to internal.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. dependencies PRs that add, update, or configure Node.js dependencies. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. strip-types Issues and PRs related to TypeScript type stripping.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants