Skip to content

src,permission: throw remaining fs errors async - #67037

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:src-permission-throw-remaining-fs-errors-async
Open

RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:src-permission-throw-remaining-fs-errors-async

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

src,permission: throw remaining fs errors async

These APIs were missed in https://github.com/nodejs/node/pull/52730.

These APIs were missed in nodejs#52730.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Oct 26, 2026
@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.66%. Comparing base (91c4436) to head (07f3055).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 11.11% 0 Missing and 16 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67037      +/-   ##
==========================================
- Coverage   92.93%   90.66%   -2.27%     
==========================================
  Files         428      797     +369     
  Lines      195236   278277   +83041     
  Branches    30176    53529   +23353     
==========================================
+ Hits       181442   252306   +70864     
- Misses      13467    16346    +2879     
- Partials      327     9625    +9298     
Files with missing lines Coverage Δ
src/node_file.cc 75.72% <11.11%> (ø)

... and 506 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS

Copy link
Copy Markdown
Member Author

PTAL @nodejs/security-wg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants