Repository navigation
Apple deployment targets: iOS 15.0, tvOS 18.0 - #8571
Merged
Merged
Conversation
- tvOS 18.0 everywhere (tvOS lib, macOS any-platform lib, tvOS template, tvOS CoreOF.xcconfig; tvOS template Project.xcconfig now sets it too) - iOS 15.0 everywhere (macOS template had 17.4, IOS_Testing 13.0) - CMake ios.toolchain defaults: iOS 15.0, tvOS 18.0, macOS 12.0, watchOS 9.0, visionOS 1.0, Mac Catalyst 15.0; explicit DEPLOYMENT_TARGET still overrides
Match openframeworks/apothecary#610: same default-comment wording and DEPLOYMENT_TARGET doc line, and the Mac Catalyst macOS fallback (CMAKE_XCODE_ATTRIBUTE_MACOSX_DEPLOYMENT_TARGET) 10.15 -> 12.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8565 (macOS minimum 12.0). Makes the iOS and tvOS minimums consistent across the core libs, templates and the CMake toolchain, in sync with openframeworks/apothecary#610 (same defaults: macOS 12.0, iOS 15.0, tvOS 18.0, watchOS 9.0, visionOS 1.0, Mac Catalyst 15.0).
tvOS → 18.0
Was a mix of 15.0 / 17.0 / 17.2 / 17.4:
libs/openFrameworksCompiled/project/tvOS/CoreOF.xcconfig(15.0)tvOS+OFLib.xcodeproj(17.2)macos/openFrameworksLib.xcodeprojtvOS configs (17.0)scripts/templates/tvOS/emptyExample.xcodeproj(17.4 / 17.2)scripts/templates/tvOS/Project.xcconfignow setsTVOS_DEPLOYMENT_TARGETexplicitly, like the iOS template doesiOS → 15.0
Core already used 15.0; fixed the outliers:
scripts/templates/macos/emptyExample.xcodeproj(17.4)apps/devApps/IOS_Testing/Project.xcconfig(13.0)CMake
ios.toolchain.cmakedefaultsOnly used when
DEPLOYMENT_TARGETisn't passed; explicit values still win.TVOSbranch, previously shared iOS's default)CMAKE_XCODE_ATTRIBUTE_MACOSX_DEPLOYMENT_TARGET) 10.15 → 12.0DEPLOYMENT_TARGETdoc line match apothecary#610 (oF's toolchain keeps its own platform names, e.g.SIMULATOR64_VISIONOS; it has noVISIONOSCOMBINED/MAC_CATALYST_UNIVERSAL)Checks
plutil -linton the edited.pbxprojfiles; the JSON template projects parseOS,OS64,SIMULATORARM64,TVOS,SIMULATOR_TVOS,SIMULATORARM64_TVOS,TVOSCOMBINED,WATCHOS,VISIONOS,MAC*,MAC_CATALYST*) → expected values;-DDEPLOYMENT_TARGET=16.4withTVOSstays 16.4