Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Single-dimension requests bypass the security limit, and several tests fail due to zero-initialized limits.
3 open findings
What changed in this PR
Adds configured maximum-resolution validation to image generation and editing requests.
Changes:
- Extracts shared request validation.
- Rejects dimensions exceeding
maxResolution. - Adds maximum-resolution unit tests.
| File | Description |
|---|---|
src/image_gen/imagegenutils.cpp |
Adds shared dimension-limit validation. |
src/test/text2image_test.cpp |
Adds resolution boundary tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if (widthIt != requestOptions.end() && heightIt != requestOptions.end()) { | ||
| auto width = widthIt->second.as<int64_t>(); | ||
| auto height = heightIt->second.as<int64_t>(); | ||
| if (width > args.maxResolution.first) { |
Comment on lines
+278
to
+280
| auto widthIt = requestOptions.find("width"); | ||
| if (widthIt != requestOptions.end()) { | ||
| auto width = widthIt->second.as<int64_t>(); |
| return ensureAcceptableForStatic(requestOptions, args); | ||
| } | ||
| return absl::OkStatus(); | ||
| SPDLOG_DEBUG("Validating request options for static reshape settings"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CWE-770
Fix for image generation api to validate requested size against configured maxResolution
🧪 Checklist
``