Repository navigation
[GR-80028] Remove PosixSupportLibrary. - #1204
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
PosixSupportLibrarywith ordinary Java methods and inheritance.Following the migration from Truffle NFI to FFM, the POSIX backend implementations gain little from Truffle partial evaluation. Path and C-string conversions still benefit from cached
TruffleStringnodes, so this change moves those conversions intoPosixSupportNodesat the call sites and executes backend operations behind@TruffleBoundary.This reduces the amount of POSIX implementation code reachable for runtime compilation while keeping string conversions visible to partial evaluation.
In detail:
NativePosixSupportrepresents paths and C strings as encoded bytes, stored inbyte[]and copied to off-heap memory for native calls. Windows paths use UTF-16LE for the wide APIs.EmulatedPosixSupportuses java.lang.String.PosixSupportNodesconverts betweenTruffleStringand these backend representations.@TruffleBoundary.