Conversation
Right axes with offset are outside ECharts containLabel; reserve ~52px per additional format so outermost tick labels are not clipped. Signed-off-by: colivi <charles.olivi@gmail.com>
Signed-off-by: colivi <charles.olivi@gmail.com>
3 tasks
jgbernalp
reviewed
Sep 28, 2026
| containLabel: false, | ||
| }; | ||
| } | ||
| const rightPad = additionalFormats.length > 0 ? additionalFormats.length * 52 + 12 : 20; |
Contributor
There was a problem hiding this comment.
Where do these magic numbers come from? a comment will be helpful here.
Contributor
|
@colivi please include screenshots of before and after, this will help reviewers to understand the fix better |
Named constants for per-axis width and margins until shared rightGridPadding is available. Signed-off-by: colivi <charles.olivi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With 2+ right Y-axes, the last axis labels were cut off even when the panel is maximized.
ECharts "containLabel" does not reserve space for right axes that use "offset".
Changes
When multi-Y is active: "grid.right = additionalFormats.length * 52 + 12"
Related
Pairs with shared "getFormattedMultipleYAxesLayout" / "rightGridPadding" (can switch to that API once shared PR perses/shared#321 is released).
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.