Repository navigation
fix(downloader): skip archives DLoad cannot unpack when a binary is expected - #164
Merged
Merged
Conversation
…xpected Such an archive downloads fine and the installation then fails with NothingExtracted after the release loop is over, so older releases that ship a supported archive were never tried. A sibling of PackageRule rather than a part of it: the report gives each removal reason its own explanation, and the supported formats come from ArchiveFactory, so a format becomes selectable as soon as an extractor is added. Closes #152 Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
PharData already opens both formats, but no matcher pointed them to TarPharArchive, so the new rule dropped them as unsupported and before it they failed with NothingExtracted. The rule recognises only its own list of archive extensions, so the docs name the skipped formats as examples rather than claiming that every other format is skipped. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
.tar.xz,.tar.bz2,.7z,.zst,.rar) is no longer selected, so the downloader moves on to an older release among the 10 newest that satisfyversion— the way OS packages are skipped since fix(downloader): skip OS packages when a binary is expected #149. A raw binary,.AppImageand other unknown extensions stay selectable;type="phar"and entries without a<binary>are unaffected, andtype="archive"already kept only supported formats..tgzand.tarare extracted now:PharDataopened them already, but no matcher pointed them to the tar extractor, so they failed withNothingExtracted.ArchiveFactory, so adding an extractor makes its format selectable again without touching the rule.Checklist
Documentation
README (all translations) and the
dload-fetch-toolskill mention unsupported archives next to OS packages.