Repository navigation
Conversation
Add IntlNumberFormatter::createFromSkeleton() so format() can render units such as "5 km/h", which NumberFormatter cannot do. Needs ICU 63+. Close phpGH-24165
LamentXU123
requested changes
Oct 12, 2026
LamentXU123
left a comment
LamentXU123
left a comment
Member
There was a problem hiding this comment.
By the way, I think you can add yourself to the CREDITS file of this extension.
| INTL_CHECK_STATUS_OR_NULL(status, "Number formatter creation failed"); | ||
|
|
||
| object_init_ex(return_value, IntlNumberFormatter_ce_ptr); | ||
| NUMBERFORMATTER_OBJECT(Z_INTL_INTLNUMBERFORMATTER_P(return_value)) = new LocalizedNumberFormatter(nf.locale(icu::Locale(locale))); |
Member
There was a problem hiding this comment.
I think you might do some checks here
--TEST--
IntlNumberFormatter preserves the region of a locale with a POSIX modifier
--EXTENSIONS--
intl
--SKIPIF--
<?php
if (!class_exists('IntlNumberFormatter')) {
die('skip IntlNumberFormatter not available');
}
?>
--FILE--
<?php
$skeleton = 'measure-unit/length-kilometer unit-width-full-name';
$plain = IntlNumberFormatter::createFromSkeleton($skeleton, 'pt_PT');
$modified = IntlNumberFormatter::createFromSkeleton($skeleton, 'pt_PT@euro');
var_dump($plain->format(12345.5) === $modified->format(12345.5));
?>
--EXPECT--
bool(true)
Member
Author
There was a problem hiding this comment.
yes it is a good point.
LamentXU123
requested changes
Oct 13, 2026
| U_CFUNC PHP_METHOD(IntlNumberFormatter, format) | ||
| { | ||
| zval *value; | ||
| NUMBERFORMATTER_METHOD_INIT_VARS; |
Member
There was a problem hiding this comment.
I think you should move this one after ZEND_PARSE_PARAMETERS_END considering about global error state ?
LamentXU123
approved these changes
Oct 13, 2026
LamentXU123
left a comment
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Thanks. This is indeed useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IntlNumberFormatter::createFromSkeleton() so format() can render units such as "5 km/h", which NumberFormatter cannot do. Needs ICU 63+.
Close GH-24165