Skip to content

Fix GH-24260: querySelectorAll() returns duplicate elements for selector lists - #24267

Open
fivefilters wants to merge 1 commit into
php:PHP-8.4from
fivefilters:fix-gh24260
Open

Fix GH-24260: querySelectorAll() returns duplicate elements for selector lists#24267
fivefilters wants to merge 1 commit into
php:PHP-8.4from
fivefilters:fix-gh24260

Conversation

@fivefilters

@fivefilters fivefilters commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Fixes #24260.

AI-assisted (Claude), reviewed by me: querySelectorAll() now passes LXB_SELECTORS_OPT_MATCH_FIRST, as querySelector(), matches() and closest() already do, so an element that matches several selectors in a list is returned once. Adds a regression test.

@fivefilters
fivefilters requested a review from devnexen as a code owner October 12, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

Assignees

No one assigned

Labels

Extension: dom

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fivefilters