Repository navigation
Fix GH-10026: Garbage collection stops after exception in SoapClient #24338
+176
−22
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| --TEST-- | ||
| GH-10026 (Garbage collection stops after exception in SoapClient) | ||
| --EXTENSIONS-- | ||
| soap | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| class A | ||
| { | ||
| public $b; | ||
| } | ||
|
|
||
| class B | ||
| { | ||
| public $a; | ||
| } | ||
|
|
||
| function buildCycle() | ||
| { | ||
| $a = new A(); | ||
| $b = new B(); | ||
| $a->b = $b; | ||
| $b->a = $a; | ||
| } | ||
|
|
||
| function failySoapCall() | ||
| { | ||
| try { | ||
| new SoapClient('https://127.0.0.1/?WSDL'); | ||
| } catch (Exception) { | ||
| echo "Soap call failed\n"; | ||
| } | ||
| } | ||
|
|
||
| function gc() | ||
| { | ||
| gc_collect_cycles(); | ||
| echo "GC Runs: " . gc_status()['runs'] . "\n"; | ||
| } | ||
|
|
||
|
|
||
| buildCycle(); | ||
| gc(); | ||
| buildCycle(); | ||
| gc(); | ||
| buildCycle(); | ||
| gc(); | ||
|
|
||
| failySoapCall(); | ||
|
|
||
| buildCycle(); | ||
| gc(); | ||
| buildCycle(); | ||
| gc(); | ||
| buildCycle(); | ||
| gc(); | ||
| ?> | ||
| --EXPECT-- | ||
| GC Runs: 1 | ||
| GC Runs: 2 | ||
| GC Runs: 3 | ||
| Soap call failed | ||
| GC Runs: 4 | ||
| GC Runs: 5 | ||
| GC Runs: 6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| --TEST-- | ||
| GH-10026 (Engine fatal errors converted to SoapFault keep the GC protected) | ||
| --EXTENSIONS-- | ||
| soap | ||
| --INI-- | ||
| memory_limit=8M | ||
| --FILE-- | ||
| <?php | ||
| class TestSoapClient extends SoapClient { | ||
| public function __doRequest($request, $location, $action, $version, $oneWay = false): ?string { | ||
| return str_repeat("x", 64 * 1024 * 1024); | ||
| } | ||
| } | ||
|
|
||
| var_dump(gc_status()["protected"]); | ||
| $client = new TestSoapClient(null, ["location" => "test://", "uri" => "urn:test"]); | ||
| try { | ||
| $client->test(); | ||
| } catch (SoapFault $e) { | ||
| echo $e->getMessage(), "\n"; | ||
| } | ||
| var_dump(gc_status()["protected"]); | ||
| ?> | ||
| --EXPECTF-- | ||
| bool(false) | ||
| Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) | ||
| bool(true) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --TEST-- | ||
| GH-10026 (WSDL errors raised by ext/soap must not leave the GC protected) | ||
| --EXTENSIONS-- | ||
| soap | ||
| --FILE-- | ||
| <?php | ||
| $wsdl = __DIR__ . "/gh10026_protected.wsdl"; | ||
| file_put_contents($wsdl, "not a wsdl at all"); | ||
|
|
||
| var_dump(gc_status()["protected"]); | ||
| try { | ||
| new SoapClient($wsdl, ["cache_wsdl" => WSDL_CACHE_NONE]); | ||
| } catch (SoapFault $e) { | ||
| echo trim($e->getMessage()), "\n"; | ||
| } | ||
| var_dump(gc_status()["protected"]); | ||
| ?> | ||
| --CLEAN-- | ||
| <?php | ||
| @unlink(__DIR__ . "/gh10026_protected.wsdl"); | ||
| ?> | ||
| --EXPECTF-- | ||
| bool(false) | ||
| SOAP-ERROR: Parsing WSDL: Couldn't load from %s | ||
| bool(false) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that s also something to definitely avoid in a stable branch.