Repository navigation
Conversation
jat255
added
bug
jat255
force-pushed
the
jat255/446-semantic-quoted-base-tables
branch
from
October 23, 2026 22:23
dc6a57f to
421986a
Compare
Contributor
|
Preview deployed to Connect ( Deployed from commit e3e563f. |
Contributor
|
Preview deployed to Connect ( Deployed from commit e3e563f. |
jat255
force-pushed
the
jat255/446-semantic-quoted-base-tables
branch
from
October 28, 2026 19:50
421986a to
f463d1c
Compare
…tifiers The view's YAML keeps a quoted name's quotes, so a base table created as "orders" was recorded as a table literally named with quotes, and scoping a source to the view's dependencies failed. Quoted names are now unquoted, with a doubled quote standing for one, and unquoted names fold to upper case. Closes #446
A namespace the YAML leaves out comes from the view's own id, which Snowflake already reports exactly, so folding it to upper case broke a view in a quoted mixed-case database or schema.
jat255
force-pushed
the
jat255/446-semantic-quoted-base-tables
branch
from
October 30, 2026 21:59
f463d1c to
b15caa1
Compare
jat255
marked this pull request as ready for review
October 30, 2026 22:17
jat255
removed
the
needs-manual-review
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #446
This PR fixes how R reads the table names in a Snowflake semantic view. Snowflake gives each name as it was written in SQL, so a table created as
"orders"came back with its quote marks, anddata_source()could not find it. R now removes the quotes from a quoted name, and changes an unquoted name to upper case, as Snowflake does.Details (agent-written)
snowflake_semantic_dependencies()now unquotes a quoted name (a doubled quote stands for one) and folds an unquoted name to upper case, which is how Snowflake resolved it when the view was created. A database or schema that the YAML leaves out comes from the view's own id, which is already exact, so it is not folded.Testing: the full R suite passes, with new cases for a quoted name, an unquoted one, an escaped quote, and an inherited mixed-case namespace. On live Snowflake, "live Snowflake scopes models associated with physical tables" passes against the views that #431 provisions.
Kata: whhh.
R changes
Reading a Snowflake semantic view now records its base tables under the names Snowflake resolved (
catalog-snowflake.R). A view over"orders"used to depend on a table literally named with quotes, anddata_source(con, tables = model$dependencies)failed with "not on the connection". It now findsorders. An unquoted lowercase name in the YAML now resolves to the upper-case table, where it used to be quoted as written.