Repository navigation
Add vignette and skill ref to reproduce analyses; add user to logged trajectories - #457
Merged
Merged
Conversation
Contributor
|
Preview deployed to Connect ( Deployed from commit f7c41d1. |
Contributor
|
Preview deployed to Connect ( Deployed from commit f7c41d1. |
skaltman
marked this pull request as ready for review
October 27, 2026 22:04
Collaborator
Author
|
I didn't rebase on #414 in case it continues to change, but there are a few things to change here once that settles and is merged:
|
# Conflicts: # pkg-r/R/commons.R # pkg-r/inst/skills/commons/SKILL.md # pkg-r/man/commons.Rd # pkg-r/tests/testthat/test-commons.R
simonpcouch
approved these changes
Oct 28, 2026
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
Contributor
|
Cleaned up 7 preview bundle(s) on https://dogfood.team.pct.posit.it: 383337, 383367, 383714, 383736, 384058, 384091, 384092 |
Contributor
|
Cleaned up 7 preview bundle(s) on https://connect.staging.pct.posit.it: 3815, 3823, 3876, 3894, 3932, 3948, 3949 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #428, although this is probably all we actually need from a reproducibility stance.
Assumes a setup where you have a commons object as in #414, so that PR should merge before this one.
Instead of creating a reproducible R script independent of commons code, this PR assumes that the author reproducing an analysis has access to the commons layers already.
Adds a vignette and skill reference to guide users and their coding agents through the process of pulling in trajectories, extracting their code, and turning it into executable R scripts.
It also assumes there will be a
commons$sql()method (or similar) to go along with #414'scommons$measure, etc. Ordinary SQL could just be wrapped in a DBI call, but queries could include dictionary references like{{revenue}}, which would need to be resolved. This isn't strictly necessary because the coding agent could just replace references itself.Also adds a user field to the logged trajectories.