Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named pipes currently fall through regular-file handling. An unrecognized filename can block while its contents are opened, and a recognized extension can classify the pipe as a regular file.
Detect FIFOs alongside the existing special file types and expose the
fifotag through the type-tag registry. Regression tests use real named pipes with and without a recognized extension and forbid opening their contents.Addresses the remaining named-pipe case in #72; socket handling is already present.
Validation:
tox -e py: 555 passed, 100% statement and branch coverage.tox -e pre-commit: all configured hooks passed.git diff --check: passed.