Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 17, 2026 21:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Readline-style completion crashes with
ZeroDivisionErrorwhen a terminal has one row: reserving the pager row leaves zero completions per page. Keep at least one content row so completion can still paginate.The regression tests cover one-row, two-row, and normal-height terminals, checking that all completions are printed and confirmation/pager calls remain correct. The one-row case fails on the unchanged base; the other two already pass. A real POSIX PTY sized to 1×12 also reports this size through
Vt100_Output.Validation
git diff --check, passed.AI-assisted implementation and regression testing.