Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 19, 2026 21:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove every matching key binding without skipping adjacent entries.
KeyBindings.remove()currently removes from the same list it is iterating, leaving some matching bindings active. This affects both removal by handler and removal by key sequence, including aliases such asenterandc-m.Iterate over a snapshot in both paths, preserving the original list object, remaining binding order, and existing cache invalidation.
Validation
git diff --checkpassed.This leaves the unrelated unknown-key error addressed by #2043 unchanged. Platform-specific mypy checks are static checks, not native OS test runs. Hosted CI status is separate from these local results.
Prepared and tested with OpenAI Codex assistance. No human review is claimed.