Repository navigation
Fix async fixture autouse=True support (issue #123) - #159
Open
VedantBhayani wants to merge 8 commits into
Open
VedantBhayani wants to merge 8 commits into
VedantBhayani wants to merge 8 commits into
Conversation
- In handle_fixture, detect autouse fixtures (via fixturedef._autouse) and store them on the test item (request.node._trio_autouse_fixtures) - In _bootstrap_fixtures_and_run_test, add autouse fixtures to test's kwargs so test waits for them, and include them in the nursery for execution - Filter out autouse fixture kwargs when calling the test function - Add comprehensive tests for autouse async fixtures
…e fixture dependencies on older pytest)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #123 - async fixtures with
autouse=Truewere not being automatically applied to tests.Changes
pytest_trio/plugin.py: Detect autouse fixtures viafixturedef._autouse, store on test item, include in nursery execution, register dependenciespytest_trio/_tests/test_autouse.py: New test file with 6 comprehensive tests covering:autouse=Truewith@pytest.mark.trioautouse=Trueintrio_mode = trueTesting
@pytest.mark.trioandtrio_mode = trueconfigurationsFixes #123.