Repository navigation
Conversation
No longer pass a pessimistic -j2 option by default. Instead, rely on --fast-ci/--slow-ci which uses -j0 by default: use os.process_cpu_count() or os.cpu_count() to decide the number of jobs to run.
Member
Author
|
--fast-ci and --slow-ci uses -j0 by default: https://github.com/python/cpython/blob/main/Lib/test/libregrtest/cmdline.py#L480-L483 When -j0 is used, libregrtest uses os.process_cpu_count() was added to Python 3.13 and is different than os.cpu_count(): it takes in account CPU affinity: https://docs.python.org/dev/library/os.html#os.process_cpu_count Example: |
|
|
||
| def create_test_opts(self, branch, worker): | ||
| testopts = [*self.testFlags, *get_j_opts(worker, 2)] | ||
| testopts = [*self.testFlags, *get_j_opts(worker)] |
Member
There was a problem hiding this comment.
This will reduce parallelism for UnixInstalledBuild which invokes regrtest directly with no --slow-ci.
Also, it may be a little risky for sanitisers to have no cap...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer pass a pessimistic -j2 option by default. Instead, rely on --fast-ci/--slow-ci which uses -j0 by default: use os.process_cpu_count() or os.cpu_count() to decide the number of jobs to run.