Repository navigation
zipfile library will raise uncaught oserror when reading length incorrect zip file #91087
Description
| BPO | 46931 |
|---|---|
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2022-03-05.17:37:33.918>
labels = ['type-bug', 'library', '3.10']
title = 'zipfile library will raise uncaught oserror when reading length incorrect zip file'
updated_at = <Date 2022-03-05.17:37:33.918>
user = 'https://bugs.python.org/ultimalium'bugs.python.org fields:
activity = <Date 2022-03-05.17:37:33.918>
actor = 'ultimalium'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2022-03-05.17:37:33.918>
creator = 'ultimalium'
dependencies = []
files = ['50658']
hgrepos = []
issue_num = 46931
keywords = []
message_count = 1.0
messages = ['414590']
nosy_count = 1.0
nosy_names = ['ultimalium']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46931'
versions = ['Python 3.10']
Activity
ultimalium commentedon Mar 5, 2022
I intentionally made some corrupted zip archive files for testing.
If some contents were removed from the archive instead of changing the bits. when trying to read such files, the zipfile will raise an uncaught OSError, instead of a badzipfile error as expected.
os is windows 10 x64 not sure if this also happens on the UNIX system or it's intended to be happen.
code:
result:
OSError
[Errno 22] Invalid argument
File "test.py", line 20, in <module>
file = dmg.testzip()
MrSeemsGood commentedon Oct 25, 2023
has this been fixed in newer versions of python? I'm getting the same error while trying to unpack a .bz2 archive on python 3.8.5, while python 3.11's zipfile returns
BadZipFileexception, as expected.serhiy-storchaka commentedon May 18, 2026
Well,
testzip()only catchesBadZipFile. It does not catch the compression errors andOSError. This is not clearly documented, and would perhaps be worth to catch the compression errors. ThisOSErrorwas caused byseek()with negative argument, which is a zipfile integrity error. Should it catch allOSErrors or only handle this particular case (offset can be checked before callingseek())?You can easy reimplement this method in your code with larger flexibility. But it seems that some people found it useful.