Repository navigation
gh-42765 timeit.Timer Documentation Update - #108744
Closed
richardhob wants to merge 9995 commits into
Closed
richardhob wants to merge 9995 commits into
richardhob wants to merge 9995 commits into
Conversation
commented
Jan 23, 2024
Contributor
|
@richardhob, can you please split this up: create a PR with the low-hanging fruit first, and then, if possible, create one PR for rewording the class docs, and one for rewording the method docs. Doc PRs that change multiple things at once are hard to review, and rarely get attention. |
…hlevel.h (pythonGH-138545) Move PYTHON_API_VERSION & PYTHON_ABI_VERSION to patchlevel.h This allows removing #include "modsupport.h" from python_ver_rc.h, which allows modsupport.h to use common helpers from Python.h -- specifically, `_Py_PACK_VERSION` for defining limited API.
… as attribute names (python#138319)
…684 (python#138651) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
docs(gc): fix typo in get_threshold() docstring Removes a duplicate "the" from the docstring for the `gc.get_threshold()` function.
This makes information about the interpreter ABI more accessible. Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
…t to connection loss (python#136743)
… produced the val… (python#138678) Opcodes which consume no inputs should indicate they produced the value, not an arbitrary local
python#138649) Adds a --no-randomize option to the CI runner, so that randomisation can be easily disabled for --fast-ci and --slow-ci configurations on single-threaded testing platforms like Android, iOS, and Emscripten. --------- Co-authored-by: Malcolm Smith <smith@chaquo.com>
…8537) While file timestamps can be anything the file system can store, most lie between the recent past and the near future. Optimize fill_time() for typical timestamps in three ways: - When possible, convert to nanoseconds with C arithmetic. - When using C arithmetic and the seconds member is not required (for st_birthtime), avoid creating a long object. - When using C arithmetic, reorder the code to avoid the null checks implied in Py_XDECREF(). Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
…s(echo_char=...)` (python#138677) In bf8bbe9, `getpass.getpass` gained the ability to provide keyboard feedback through `echo_char`. On Unix, line editing shortcuts such as Ctrl+U were previously handled as the terminal operates in canonical mode (see termios(3)). However, since keyboard feedback requires to switch to noncanonical mode, this now results in an inconsistency when `getpass.getpass` uses `echo_char` as those shortcuts are no more supported. This limitation is specific to Unix and does not affect Windows users where line editing shortcuts were never supported.
…38698) Follow-up refactoring after pythonGH-133143, where we use `_Py_ID` for "big" and "little" in `abi_info.byteorder`. This uses `_Py_ID` for `sys.byteorder`, but also `float_repr_style` and a module name.
…H-137167) The codecs lookup function now performs only minimal normalization of the encoding name before passing it to the search functions: all ASCII letters are converted to lower case, spaces are replaced with hyphens. Excessive normalization broke third-party codecs providers, like python-iconv. Revert "bpo-37751: Fix codecs.lookup() normalization (pythonGH-15092)" This reverts commit 20f59fe.
richardhob
requested review from
a team,
1st1,
Eclips4,
Fidget-Spinner,
ZeroIntensity,
abalkin,
asvetlov,
brandtbucher,
brettcannon,
corona10,
diegorusso,
ericsnowcurrently,
ericvsmith,
freakboy3742,
hugovk,
iritkatriel,
isidentical,
markshannon,
mhsmith,
ncoghlan,
pganssle,
picnixz,
savannahostrowski,
serhiy-storchaka,
tiran and
willingc
as code owners
September 24, 2025 14:51
commented
Sep 24, 2025
|
The following commit authors need to sign the Contributor License Agreement: |
AlexWaygood
removed their request for review
September 24, 2025 14:59
commented
Sep 24, 2025
Member
|
That force push was broken (maybe you merged 3.14 in?) and resulted in a large number of review requests, please create a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
timeitdocumentation based on discussion in issue #42765.Resolve Issue #42765
This issue discusses the documentation for the
timeit.Timerclass, as well as possible improvements.elibenderskyprovided a patch to update the documentation, andrurpyimproved on this in a post. This merge request implementsrurpy's version of thetimeit.Timerclass documentation with some light edits.The goal of this documentation change is to better explain how to use
timeit.Timer, what the input arguments are, and how the args are use to actually time the execution of the provided snippet.📚 Documentation preview 📚: https://cpython-previews--108744.org.readthedocs.build/