[kanavin]

reading stdin can throw the same I/O errors as reading from master fd does,
e.g. when running under Yocto's test harness:

ERROR: test_spawn_doesnt_hang (test.test_pty.PtyTest)

Traceback (most recent call last):
File "/usr/lib/python3.10/test/test_pty.py", line 316, in test_spawn_doesnt_hang
pty.spawn([sys.executable, '-c', 'print("hi there")'])
File "/usr/lib/python3.10/pty.py", line 181, in spawn
_copy(master_fd, master_read, stdin_read)
File "/usr/lib/python3.10/pty.py", line 157, in _copy
data = stdin_read(STDIN_FILENO)
File "/usr/lib/python3.10/pty.py", line 132, in _read
return os.read(fd, 1024)
OSError: [Errno 5] Input/output error

So let's treat both channels the same.

Signed-off-by: Alexander Kanavin alex@linutronix.de

https://bugs.python.org/issue45223

• Issue: test_spawn_doesnt_hang (test.test_pty.PtyTest) fails when stdin isn't readable #89386

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@kanavin

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

[github-actions]

This PR is stale because it has been open for 30 days with no activity.

[kanavin]

Just signed the CLA, will check in a few days if it's active.

[CoolCat467]

@kanavin Just checked now and it still says no

[kanavin]

@kanavin Just checked now and it still says no

If i type @kanavin into https://check-python-cla.herokuapp.com/ I get 500 Internal server error. How did you check?

[CoolCat467]

Need to use kanavin, without @ symbol

[kanavin]

Need to use kanavin, without @ symbol

Right, I had it set on bpo with @. I removed that, and it looks good now.

[MaxwellDupre]

Looks good:
Ran 7 tests in 0.049s

OK (expected failures=1)

== Tests result: SUCCESS ==

[netlify]

✅ Deploy Preview for python-cpython-preview canceled.

Name	Link
🔨 Latest commit	3c3c3bb
🔍 Latest deploy log	https://app.netlify.com/sites/python-cpython-preview/deploys/63905060686239000ad92955

[furkanonder]

@kanavin Can you explain the way to reproduce the error? I would like to try this in my local and check if the error still exists.

[kanavin]

@kanavin Can you explain the way to reproduce the error? I would like to try this in my local and check if the error still exists.

We use this to run the tests:
https://git.yoctoproject.org/ptest-runner2/tree/

I just confirmed: when running python3 -m test.test_pty -v directly on the terminal it passes. When the same command is executed by ptest-runner with i/o handled by it, it fails as shown above.

[github-actions]

This PR is stale because it has been open for 30 days with no activity.