Repository navigation
Allow valid targets alongside empty directories - #22177
Open
nightcityblade wants to merge 1 commit into
Open
nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
nightcityblade
force-pushed
the
fix/issue-22173
branch
from
October 11, 2026 05:11
df7271d to
cbdd1f3
Compare
Author
|
Fixed the Windows-only test expectation in 7d71289 by accepting both POSIX and drive-prefixed Windows separators. I also folded pre-commit.ci’s import-spacing auto-fix into the authored commit, preserving single-commit history. The focused 10-test suite passed before the formatting-only bot change; the final tree passes Ruff, ruff format, py_compile, and git diff --check. CI is rerunning. |
nightcityblade
force-pushed
the
fix/issue-22173
branch
from
October 11, 2026 05:21
818d87f to
db5c22b
Compare
nightcityblade
force-pushed
the
fix/issue-22173
branch
from
October 11, 2026 05:21
db5c22b to
7d71289
Compare
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22173
create_source_list now defers the existing empty-directory error until all explicit targets have been scanned. This lets mypy check valid targets alongside an empty directory while preserving the fatal error when no sources are found.
A regression test covers both the mixed-target and all-empty cases.
Validation:
AI assistance: Codex helped draft the focused change and test; I reviewed the diff and ran all validation locally.